Page MenuHomePhabricator
Create Task
Maniphest T281804

Replace die() with proper error reporting
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Replace die() in all Classes and replace them with proper error reporting

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 4 2021, 9:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2021, 9:00 AM
Lucas_Werkmeister_WMDE claimed this task.May 5 2021, 3:05 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Wikibase OPEN!NEXT board.

I’ll get started on this, but I think this can be done in several parts, given that the die() calls are currently a bit scattered across the codebase.

Lucas_Werkmeister_WMDE moved this task from Doing to Ready for Review on the Wikibase OPEN!NEXT board.May 6 2021, 3:05 PM
• toan moved this task from Ready for Review to Verification on the Wikibase OPEN!NEXT board.May 7 2021, 12:49 PM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 7 2021, 1:20 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Backlog on the Wikibase OPEN!NEXT board.

Not done yet.

guergana.tzatchkova claimed this task.May 10 2021, 8:42 AM
guergana.tzatchkova moved this task from Backlog to Sprint Backlog on the Wikibase OPEN!NEXT board.
guergana.tzatchkova moved this task from Sprint Backlog to Doing on the Wikibase OPEN!NEXT board.
conny-kawohl_WMDE edited projects, added Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1); removed Wikibase OPEN!NEXT.May 10 2021, 10:05 AM
Lucas_Werkmeister_WMDE moved this task from Sprint Backlog to Doing on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 10 2021, 10:08 AM
conny-kawohl_WMDE updated the task description. (Show Details)May 10 2021, 10:13 AM
conny-kawohl_WMDE set the point value for this task to 5.
guergana.tzatchkova added a comment.May 12 2021, 1:08 PM

Still not finished, but could use some review on first commit
https://github.com/wmde/WikibaseReconcileEdit/pull/18/

Lucas_Werkmeister_WMDE mentioned this in T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest .May 14 2021, 9:43 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 17 2021, 2:18 PM

Current PR: https://github.com/wmde/WikibaseReconcileEdit/pull/25

guergana.tzatchkova moved this task from Review to Doing on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 19 2021, 8:26 AM
guergana.tzatchkova added a comment.EditedMay 19 2021, 3:41 PM

Third and last PR: https://github.com/wmde/WikibaseReconcileEdit/pull/31

guergana.tzatchkova moved this task from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 19 2021, 3:41 PM
Lucas_Werkmeister_WMDE moved this task from Review to Verify on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 20 2021, 3:55 PM
Lucas_Werkmeister_WMDE moved this task from Verify to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 21 2021, 11:43 AM

Fourth and extra-last PR: https://github.com/wmde/WikibaseReconcileEdit/pull/33

• toan moved this task from Review to Verify on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 21 2021, 3:20 PM
• toan closed this task as Resolved.May 21 2021, 3:29 PM
Lucas_Werkmeister_WMDE moved this task from Verify to Done on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.May 25 2021, 8:11 AM
Lucas_Werkmeister_WMDE mentioned this in T284051: Rename i18n messages.Jun 1 2021, 9:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL