Page MenuHomePhabricator
Create Task
Maniphest T281817

Function Call and Reference in mode selector break flow (regression from JSON editing more)
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Access the Create new object page
  • Select a Z8 pas type for Z2K2
  • Select Reference or Function Call from the mode selector dropdown

What happens?:

  • The mode selector will lose the Generic and Literal mode and set the wrong literal type

What should have happened instead?:

  • The lietarl and generic mode should still be on, and The literal type should still be set to Z8

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

SubjectRepoBranchLines +/-
Fix Function Call and Reference in mode selector to not reset the typemediawiki/extensions/WikiLambdamaster+34 -13
Customize query in gerrit

Event Timeline

SimoneThisDot claimed this task.May 4 2021, 11:07 AM
SimoneThisDot created this task.
SimoneThisDot renamed this task from Function Call and Reference in mode selector unexpected behaviour when zObject type is not defined to Function Call and Reference in mode selector break flow (regression from JSOn editing more).May 4 2021, 12:03 PM
gerritbot added a comment.May 4 2021, 2:29 PM

Change 684955 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Function Call and Reference in mode selector break flow

https://gerrit.wikimedia.org/r/684955

gerritbot added a project: Patch-For-Review.May 4 2021, 2:29 PM
SimoneThisDot triaged this task as High priority.May 4 2021, 8:14 PM
DVrandecic renamed this task from Function Call and Reference in mode selector break flow (regression from JSOn editing more) to Function Call and Reference in mode selector break flow (regression from JSON editing more).May 5 2021, 1:03 AM
gerritbot added a comment.May 5 2021, 3:58 PM

Change 684955 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix Function Call and Reference in mode selector to not reset the type

https://gerrit.wikimedia.org/r/684955

Jdforrester-WMF closed this task as Resolved.May 5 2021, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL