extensions/AbuseFilter - Use UserGroupManager instead of User group methods
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Vlad.shapik
	May 4 2021, 12:03 PM

Description

Replace getEffectiveGroups() in AbuseFilterConsequencesTest with MediaWikiServices::getInstance()->getUserGroupManager()->getUserEffectiveGroups( $this->user ).

Details

	Subject	Repo	Branch	Lines +/-
	Replace deprecated User::getEffectiveGroups	mediawiki/extensions/AbuseFilter	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T277511 Drop hard-deprecated User methods once they've been hard-deprecated in at least once release
Open	None	T274211 Finish hard-deprecation and removal of User methods depecated prior to MW 1.36
Resolved	• Pchelolo	T234921 Factor group membership management out of User class
Resolved	Umherirrender	T275148 Prepare User group methods for hard deprecation
Resolved	Daimona	T281824 extensions/AbuseFilter - Use UserGroupManager instead of User group methods

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 4 2021, 12:03 PM

Vlad.shapik created this task.

Daimona updated the task description. (Show Details)May 4 2021, 12:07 PM

Daimona edited projects, added AbuseFilter; removed AbuseFilter (Overhaul-2020).

Change 685794 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] Replace deprecated User::getEffectiveGroups

https://gerrit.wikimedia.org/r/685794

gerritbot added a project: Patch-For-Review.May 6 2021, 1:36 PM

Daimona claimed this task.May 6 2021, 1:36 PM

Vlad.shapik renamed this task from extensions/AbuseFilter - hard deprecate User group methods to extensions/AbuseFilter - Use UserGroupManager instead of User group methods.May 6 2021, 2:33 PM

Change 685794 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Replace deprecated User::getEffectiveGroups

https://gerrit.wikimedia.org/r/685794

Daimona closed this task as Resolved.May 6 2021, 2:39 PM

Daimona removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).May 6 2021, 3:00 PM

Vlad.shapik removed a project: Technical-Debt (Deprecation process).Jul 27 2021, 7:31 AM