Page MenuHomePhabricator

extensions/LDAPGroups - Use UserGroupManager instead of User group methods
Closed, ResolvedPublic

Description

Find all usages of:

  • public function getGroups()
  • public function getGroupMemberships()
  • public function getEffectiveGroups()
  • public function getAutomaticGroups()
  • public function getFormerGroups()
  • public function addGroup()
  • public function removeGroup()
  • public function addAutopromoteOnceGroups())

and need to be replaced with corresponding UserGroupManager methods.
You can obtain UserGroupManager via MediaWikiServices::getInstance()->getUserGroupManager(), but it's preferred to inject it if possible.

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 4 2021, 1:04 PM
Vlad.shapik created this task.
Vlad.shapik renamed this task from extensions/LDAPGroups - hard deprecate User group methods to extensions/LDAPGroups - Use UserGroupManager instead of User group methods.May 6 2021, 2:36 PM

Change 699924 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LDAPGroups@master] Replace deprecated User group methods

https://gerrit.wikimedia.org/r/699924

Thanks! I will review as soon as possible!

Change 710396 had a related patch set uploaded (by Robert Vogel; author: Vlad.shapik):

[mediawiki/extensions/LDAPGroups@REL1_35] Replace deprecated User group methods

https://gerrit.wikimedia.org/r/710396

Change 699924 merged by jenkins-bot:

[mediawiki/extensions/LDAPGroups@master] Replace deprecated User group methods

https://gerrit.wikimedia.org/r/699924

Change 710578 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LDAPGroups@master] Bump the MW version

https://gerrit.wikimedia.org/r/710578

Change 710578 merged by jenkins-bot:

[mediawiki/extensions/LDAPGroups@master] Bump the MW version

https://gerrit.wikimedia.org/r/710578

Change 710396 abandoned by Umherirrender:

[mediawiki/extensions/LDAPGroups@REL1_35] Replace deprecated User group methods

Reason:

No need to backport into 1.35 when version bumped

https://gerrit.wikimedia.org/r/710396