Page MenuHomePhabricator

BlueSpice related extensions - Use UserGroupManager instead of User group methods
Closed, ResolvedPublic

Description

There are usages some of User group methods in the following extensions:

  • extensions / BlueSpiceFoundation
  • extensions / BlueSpiceDashboards
  • extensions / BlueSpiceFlaggedRevsConnector
  • extensions / BlueSpicePageAccess
  • extensions / BlueSpiceUserManager
  • extensions / BlueSpiceSMWConnector

Find all usages of:

  • public function getGroups()
  • public function getGroupMemberships()
  • public function getEffectiveGroups()
  • public function getAutomaticGroups()
  • public function getFormerGroups()
  • public function addGroup()
  • public function removeGroup()
  • public function addAutopromoteOnceGroups()

and need to be replaced with corresponding UserGroupManager methods.
You can obtain UserGroupManager via MediaWikiServices::getInstance()->getUserGroupManager(), but it's preferred to inject it if possible.

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 4 2021, 1:23 PM
Vlad.shapik created this task.
Vlad.shapik renamed this task from extensions/BlueSpiceDashboards - hard deprecate User group methods to BlueSpice related extensions - hard deprecate User group methods.May 4 2021, 1:47 PM
Vlad.shapik updated the task description. (Show Details)
Vlad.shapik renamed this task from BlueSpice related extensions - hard deprecate User group methods to BlueSpice related extensions - Use UserGroupManager instead of User group methods.May 6 2021, 2:39 PM

Change 697431 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceFoundation@master] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/697431

Change 697433 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceDashboards@master] Avoid using User::getGroups()

https://gerrit.wikimedia.org/r/697433

Change 697435 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/697435

Change 697449 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpicePageAccess@master] Avoid using User::getGroups()

https://gerrit.wikimedia.org/r/697449

Change 697450 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceUserManager@master] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/697450

Change 697452 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceSMWConnector@master] Avoid using User::getEffectiveGroups()

https://gerrit.wikimedia.org/r/697452

Change 697433 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceDashboards@master] Avoid using User::getGroups()

https://gerrit.wikimedia.org/r/697433

Change 697449 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePageAccess@master] Avoid using User::getGroups()

https://gerrit.wikimedia.org/r/697449

Change 697450 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceUserManager@master] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/697450

Change 697431 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFoundation@master] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/697431

Change 697452 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSMWConnector@master] Avoid using User::getEffectiveGroups()

https://gerrit.wikimedia.org/r/697452

Change 698530 had a related patch set uploaded (by Robert Vogel; author: Zabe):

[mediawiki/extensions/BlueSpiceSMWConnector@REL1_35] Avoid using User::getEffectiveGroups()

https://gerrit.wikimedia.org/r/698530

Change 698530 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSMWConnector@REL1_35] Avoid using User::getEffectiveGroups()

https://gerrit.wikimedia.org/r/698530

Change 697435 merged by Pwirth:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/697435

Zabe updated the task description. (Show Details)

Change 745268 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/745268

Change 745230 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35-4.0.x] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/745230

Change 745230 merged by Pwirth:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35-4.0.x] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/745230

Change 745268 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using deprecated User group methods

https://gerrit.wikimedia.org/r/745268