Page MenuHomePhabricator

extensions/ShoutWikiAds - Use UserGroupManager instead of User group methods
Closed, ResolvedPublic

Description

Find all usages of:

  • public function getGroups()
  • public function getGroupMemberships()
  • public function getEffectiveGroups()
  • public function getAutomaticGroups()
  • public function getFormerGroups()
  • public function addGroup()
  • public function removeGroup()
  • public function addAutopromoteOnceGroups())

and need to be replaced with corresponding UserGroupManager methods.
You can obtain UserGroupManager via MediaWikiServices::getInstance()->getUserGroupManager(), but it's preferred to inject it if possible.

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 4 2021, 2:58 PM
Vlad.shapik created this task.
Vlad.shapik renamed this task from extensions/ShoutWikiAds - hard deprecate User group methods to extensions/ShoutWikiAds - Use UserGroupManager instead of User group methods.May 6 2021, 2:47 PM

Change 702155 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ShoutWikiAds@master] Avoid using User group methods

https://gerrit.wikimedia.org/r/702155

Change 702155 merged by jenkins-bot:

[mediawiki/extensions/ShoutWikiAds@master] Avoid using User group methods

https://gerrit.wikimedia.org/r/702155

Change 728531 had a related patch set uploaded (by Umherirrender; author: Vlad.shapik):

[mediawiki/extensions/ShoutWikiAds@REL1_37] Avoid using User group methods

https://gerrit.wikimedia.org/r/728531

Change 728531 merged by jenkins-bot:

[mediawiki/extensions/ShoutWikiAds@REL1_37] Avoid using User group methods

https://gerrit.wikimedia.org/r/728531