Page MenuHomePhabricator

Check whether User::pingLimiter can now use incr() and changeTTL() instead of the lock()/merge() workaround
Open, Needs TriagePublic

Description

/cc @aaron @daniel

During an unrelated conversation today, Aaron and I walked into this code and were wondering whether the overhead/workaround is still needed. This is a placeholder to look into that at some point.

Related context:

Event Timeline

Memcached alledgedly retaining values too long. I don't know if we've since confirmed this.

I forgot about T246991, but out of curiosity I've just went to logstash and searched for the debug message added in r622541. That case was triggered roughly 400 times in the last 15 minutes, which seems very wrong to me.