Maniphest T281933

Mailman3 import script is unnecessarily truncating list descriptions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 4 2021, 11:19 PM

Description

In T280322#7054296, @Ladsgroup wrote:

The import script cuts the description while it doesn't need to.

https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/utilities/importer.py#L198

Even though we made the column bigger, the model is still SAUnicode, so it thinks it needs to truncate. I can cherry-pick the model change and upload a new mailman package so that the import script stops truncating.

Details

	Subject	Repo	Branch	Lines +/-
	mailman3: Copy "info" field over manually	operations/puppet	production	+26 -0

Customize query in gerrit

Related Objects

Mentioned In: T282092: Upload new mailman3 and hyperkitty packages
Mentioned Here: T280322: Upgrade mailing lists from mailman2 to 3 in batches

Event Timeline

Legoktm created this task.May 4 2021, 11:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2021, 11:19 PM

Maintenance_bot added a project: SRE.May 4 2021, 11:45 PM

One thing I was thinking was that we can simply set the description from the old file (similar to how we handle templates), post-creation if that's easier than cherry-picking upstream

Change 685212 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] mailman3: Copy "info" field over manually

https://gerrit.wikimedia.org/r/685212

gerritbot added a project: Patch-For-Review.May 5 2021, 4:26 AM

In T281933#7060186, @Ladsgroup wrote:

One thing I was thinking was that we can simply set the description from the old file (similar to how we handle templates), post-creation if that's easier than cherry-picking upstream

Yep, much easier :D

Ladsgroup moved this task from Backlog to Mailman v3 on the Wikimedia-Mailing-lists board.May 5 2021, 3:34 PM

Change 685212 merged by Legoktm:

[operations/puppet@production] mailman3: Copy "info" field over manually

https://gerrit.wikimedia.org/r/685212

Legoktm closed this task as Resolved.May 5 2021, 7:08 PM

Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 7:10 PM

Legoktm mentioned this in T282092: Upload new mailman3 and hyperkitty packages.May 6 2021, 6:42 PM