Maniphest T281935

It should be safe to create exceptions without using the global state
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	DannyS712
	May 4 2021, 11:20 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Tokens

"Like" token, awarded by Mainframe98.

Description

This came up in a patch dealing with MediaWikiTitleCodec in unit tests, where MalformedTitleException could not be created, but applies to other classes too. These exceptions use the global state when being created. Applies to

MalformedTitleException
LocalizedException
ApiUsageException
ErrorPageError and subclasses
UploadChunkVerificationException
UploadStashException

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T281935 It should be safe to create exceptions without using the global state
		Open		None	T287405 Refactor ILocalizedException to be DI-friendly.

Event Timeline

DannyS712 created this task.May 4 2021, 11:20 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 4 2021, 11:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.May 4 2021, 11:21 PM

DannyS712 updated the task description. (Show Details)May 22 2021, 3:32 AM

DannyS712 added a subscriber: • Pchelolo.Jun 7 2021, 10:55 AM

Mainframe98 awarded a token.Jul 26 2021, 6:54 PM

Nikerabbit subscribed.Jul 28 2021, 6:53 AM

taavi subscribed.Aug 13 2021, 2:00 PM

Zabe subscribed.Aug 13 2021, 10:54 PM

Daimona subscribed.Feb 18 2022, 1:26 PM

Jdforrester-WMF subscribed.May 17 2023, 9:27 AM

DannyS712 added a project: MediaWiki-General.Jan 10 2024, 1:30 PM