Page MenuHomePhabricator

Remove language button from commons
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

For logged in users that have opted out of legacy vector, the language button should not appear on Commons or other wikis that have multiple languages within the same domain. The language switching functionality on Commons exists to switch the interface language and is controlled via the link at the top. The button introduced by the change linked to the Wikipedia links currently available in the sidebar, making it difficult to distinguish its functionality.

Acceptance criteria

  • Remove new language switcher from: Commons, Wikidata, Mediawiki, Wikispecies,

https://phabricator.wikimedia.org/T281968#7099849

QA Results - Beta

Event Timeline

Change 685795 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies

https://gerrit.wikimedia.org/r/685795

Change 685795 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies

https://gerrit.wikimedia.org/r/685795

Mentioned in SAL (#wikimedia-operations) [2021-05-10T11:26:56Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 9209d96560777cf6747d57855c7b525e702664d7: Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies (T281968) (duration: 00m 57s)

Edtadros added subscribers: Jdlrobson, Edtadros.

Status:
Environment: beta/xyzwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

For logged in users that have opted out of legacy vector, the language button should not appear on the following:

✅ AC1: Commons https://commons.wikimedia.beta.wmflabs.org/wiki/Commons:Welcome


❓ AC2: Wikidata https://wikidata.beta.wmflabs.org/wiki/Q500973

❓ AC3: Mediawiki https://www.mediawiki.org/wiki/Help:Editing_pages

❓ AC4: Wikispecies https://species.wikimedia.org/wiki/Michotamia_aurata

@Jdlrobson Is the page for AC2 a good example for testing or is there another page that would have languages in the sidebar? Regarding AC3 and AC4, I couldn't find a "beta" site. I took the screenshots anyways, but I'm not sure if those wikis have this patch.

Remove new language switcher from: Commons, Wikidata, Mediawiki, Wikispecies,

@Edtadros this looks correct.

@ovasileva: sign off question... can we:

  1. update the description to explain why the change happened here so we can refer back to it
  2. create a new ticket explaining the long-term solution here

The feature flag for the language button was envisioned as a temporary solution and loads double the CSS it needs to. Therefore this task has lead to product/technical debt. It's my opinion we can't sustainably support 2 treatments for languages in the future IMO, so it would be good to understand how we can pay this debt off before the end of the project.

@Jdlrobson - added some background above. I think our main issue is that we have 2 treatments because we have 2 different sets of functionality for single language wikis and multiple language wikis:

  1. These wikis do not have the same behavior as others. If we present a button at the top of the page, that button takes you to a different project (rather than a different language version).
  1. Language switching is available at the top of these wikis. Here it controls the interface language of the wikis (rather than the language of the content)

Will discuss further with @alexhollender and set up a follow-up task

Resolving this for now and scheduled a discussion with @alexhollender on next steps