Page MenuHomePhabricator

extensions/CentralAuth - use SessionProvider ::init, ::postInitSetup instead of the setters of SessionProvider
Closed, ResolvedPublic

Description

  1. Provided that the following methods are used only in tests, all usages of deprecated SessionProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer methods must be replaced with SessionProvider ::init.
  2. If it's overridden SessionProvider ::setConfig or SessionProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer are used outside the test codebase of the extension, so replace it with SessionProvider::postInitSetup to do any necessary setup.

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 5 2021, 2:47 PM
Vlad.shapik created this task.
Vlad.shapik renamed this task from extensions/CentralAuth - hard deprecate setters of AbstractAuthenticationProvider class to extensions/CentralAuth - hard deprecate the setters of AbstractAuthenticationProvider class .May 5 2021, 2:49 PM
Vlad.shapik renamed this task from extensions/CentralAuth - hard deprecate the setters of AbstractAuthenticationProvider class to extensions/CentralAuth - hard deprecate the setters of SessionProvider class .May 5 2021, 4:01 PM
Vlad.shapik updated the task description. (Show Details)
Vlad.shapik updated the task description. (Show Details)

Change 685531 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CentralAuth@master] Hard deprecate the setters of SessionProvider class

https://gerrit.wikimedia.org/r/685531

Vlad.shapik renamed this task from extensions/CentralAuth - hard deprecate the setters of SessionProvider class to extensions/CentralAuth - use SessionProvider ::init, ::postInitSetup instead of the setters of SessionProvider .May 6 2021, 2:59 PM

Change 685531 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Replace uses of the deprecated setters of SessionProvider class

https://gerrit.wikimedia.org/r/685531