Page MenuHomePhabricator

extensions/EmailAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Closed, ResolvedPublic

Description

  1. Provided that the following methods are used only in tests, all usages of deprecated AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer methods must be replaced with AbstractAuthenticationProvider::init.
  2. If it's overridden AbstractAuthenticationProvider::setConfig or AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer are used outside the test codebase of the extension, so replace it with AbstractAuthenticationProvider::postInitSetup to do any necessary setup.

Event Timeline

Vlad.shapik triaged this task as Medium priority.
Vlad.shapik renamed this task from extensions/EmailAuth - hard deprecate the setters of AbstractAuthenticationProvider class to extensions/EmailAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider.May 6 2021, 2:57 PM

Change 686563 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/EmailAuth@master] Replace uses of the deprecated setters of AbstractAuthenticationProvider

https://gerrit.wikimedia.org/r/686563

Change 686563 merged by jenkins-bot:

[mediawiki/extensions/EmailAuth@master] Replace uses of the deprecated setters of AbstractAuthenticationProvider

https://gerrit.wikimedia.org/r/686563