Page MenuHomePhabricator
Create Task
Maniphest T281996

extensions/PasswordlessLogin - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Closed, ResolvedPublic
Actions

Description

  1. Provided that the following methods are used only in tests, all usages of deprecated AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer methods must be replaced with AbstractAuthenticationProvider::init.
  2. If it's overridden AbstractAuthenticationProvider::setConfig or AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer are used outside the test codebase of the extension, so replace it with AbstractAuthenticationProvider::postInitSetup to do any necessary setup.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace uses of the deprecated setters of AbstractAuthenticationProvidermediawiki/extensions/PasswordlessLoginmaster+14 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Vlad.shapik created this task.May 5 2021, 2:59 PM
Vlad.shapik triaged this task as Medium priority.
Vlad.shapik updated the task description. (Show Details)May 5 2021, 4:07 PM
Vlad.shapik renamed this task from extensions/PasswordlessLogin - hard deprecate the setters of AbstractAuthenticationProvider class to extensions/PasswordlessLogin - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider.May 6 2021, 2:57 PM
gerritbot added a comment.May 7 2021, 3:21 PM

Change 686627 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/PasswordlessLogin@master] Replace uses of the deprecated setters of AbstractAuthenticationProvider

https://gerrit.wikimedia.org/r/686627

gerritbot added a project: Patch-For-Review.May 7 2021, 3:21 PM
Vlad.shapik moved this task from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.May 7 2021, 3:53 PM
Vlad.shapik closed this task as Resolved.May 26 2021, 8:36 AM
gerritbot added a comment.Oct 19 2021, 2:15 PM

Change 686627 abandoned by Vlad.shapik:

[mediawiki/extensions/PasswordlessLogin@master] Replace uses of the deprecated setters of AbstractAuthenticationProvider

Reason:

It was fixed in this patch ->> I139b2f508ec99457ab03a02224c9e500ae006b62

https://gerrit.wikimedia.org/r/686627

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 3:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits