Page MenuHomePhabricator

Add mailman-templates to translatewiki.net
Closed, ResolvedPublic

Description

Project information

Name: mailman-templates
Homepage: https://wikitech.wikimedia.org/wiki/Mailman#Templates
Project link: https://gerrit.wikimedia.org/g/operations/software/mailman-templates/
Code repository: https://gerrit.wikimedia.org/g/operations/software/mailman-templates/

  • Source branch: master
  • Target branch: master

OS License: GPL-3.0-or-later
Issue Tracker: Wikimedia-Mailing-lists
Project contact: User:Legoktm / @Legoktm

Logo: Don't have one, is this required?

  • Without text:
  • With text:

Project description:
Customized email templates for Mailman3. These templates improve upon the upstream ones by providing links to the web interface where appropriate.

Translations should only be enabled for ['ar', 'ast', 'ca', 'cs', 'da', 'de', 'el', 'en', 'es', 'et', 'eu', 'fi', 'fr', 'gl', 'he', 'hr', 'hu', 'ia', 'it', 'ja', 'ko', 'lt', 'nl', 'no', 'pl', 'pt', 'pt_BR', 'ro', 'ru', 'sk', 'sl', 'sr', 'sv', 'tr', 'uk', 'vi', 'zh_CN', 'zh_TW']

NOTE: Section below will be filled by twn staff

Project setup checklist

Project configuration (for translation admins)

Namespace: Wikimedia
Prefix: wikimedia-mailman-templates-
Validators: For variables, may need a custom regexp

Concerns

  • Why are there empty messages?
  • Some messages contain literal tabs, which will be hard to input for translators
  • Is there difference between $foo and ${foo} variable syntax, or could they be unified?
  • Is sr expected to be in Latin or Cyrillic script?

Event Timeline

Ladsgroup triaged this task as Medium priority.May 5 2021, 8:55 PM
Nikerabbit subscribed.

@Legoktm I added a few questions to the description and Nemo_bis has left similar ones in the qqq patch. Logo is not needed.

Change 692330 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[translatewiki@master] WIP: Add Wikimedia Mailman templates

https://gerrit.wikimedia.org/r/692330

I'm a bit behind on this, some other higher priority MM issues have come up, but I'm still trying to make progress on it.

  • Why are there empty messages?
    • Nemo pointed this out as well, I'll delete them.
  • Some messages contain literal tabs, which will be hard to input for translators
    • Would 4 spaces work better? These are all plain text so indentation is used for formatting. Some lines do have a leading space before URLs which is required to be there.
  • Is there difference between $foo and ${foo} variable syntax, or could they be unified?
    • ${foo}bar is $foo plus "bar" while $foobar is $foobar. We can use the ${foo} syntax everywhere.
  • Is sr expected to be in Latin or Cyrillic script?

I'm a bit behind on this, some other higher priority MM issues have come up, but I'm still trying to make progress on it.

No worries, you're doing important stuff.

  • Some messages contain literal tabs, which will be hard to input for translators
    • Would 4 spaces work better? These are all plain text so indentation is used for formatting. Some lines do have a leading space before URLs which is required to be there.

Yes.

  • Is there difference between $foo and ${foo} variable syntax, or could they be unified?
    • ${foo}bar is $foo plus "bar" while $foobar is $foobar. We can use the ${foo} syntax everywhere.

+1 for consistency

The comment says the list is derived from Mailman 2. Did it have translations there?

The comment says the list is derived from Mailman 2. Did it have translations there?

https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/head:/messages/sr/LC_MESSAGES/mailman.po so Cyrillic

Pushed some new commits, I think I've addressed all the feedback so far.

Change 704281 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Add Wikimedia Mailman Templates

https://gerrit.wikimedia.org/r/704281

Change 704281 merged by jenkins-bot:

[translatewiki@master] Add Wikimedia Mailman Templates

https://gerrit.wikimedia.org/r/704281

The patch has been deployed, and we can now translate the project here: https://translatewiki.net/wiki/Special:Translate/wikimedia-mailman-templates

Exports will happen today at around 1100 UTC

Change 692330 abandoned by Nikerabbit:

[translatewiki@master] WIP: Add Wikimedia Mailman templates

Reason:

See https://gerrit.wikimedia.org/r/c/translatewiki/ /704281

https://gerrit.wikimedia.org/r/692330

A few things to do:

  1. Message documentation has been added. Ensure that they appear properly.
  2. Enable translations to message documentation on translatewiki.net
  3. No exports yesterday, possibly because there were no translations yet. Check again on 22nd Jul.

Jenkins bot never voted on it. It should have the right to.

Change 685938 merged by jenkins-bot:

[integration/config@master] Zuul: [operations/software/mailman-templates] Add CI of debian-glue

https://gerrit.wikimedia.org/r/685938

The config change adds:

gate-and-submit-l10n:
  - debian-glue

The debian-glue job only runs for changes affecting a file in the ./debian directory, it is otherwise not triggered. Since L10n-bot only touches ./i18n/* (example), the job is never run, the gate-and-submit-l10n pipeline does not run any job and the change is left idling waiting for job success that will never come.

Other repositories have the job mediawiki-i18n-check-docker which run the diff through a large sed that attempts to detect HTML. So I guess we should use that job and drop debian-glue.

Change 706443 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: [mailman-templates] use i18n checker

https://gerrit.wikimedia.org/r/706443

Change 706443 merged by jenkins-bot:

[integration/config@master] zuul: [mailman-templates] use i18n checker

https://gerrit.wikimedia.org/r/706443

The job fails due to:

+	"help": "Aide pour la liste de diffusion ${listname}\n\nC’est la commande de courriel 'help' pour la version ${version} du gestionnaire de liste\nGNU Mailman sur ${domain}.  Ce qui suit décrit les commandes que vous pouvez envoyer pour obtenir\nde l’information sur le sujet et contrôler votre abonnement aux listes sur ce site.\nUne commande peut être dans la ligne Sujet ou dans le corps du message.\n\nLes commandes doivent être envoyées à l’adresse ${listname}-request@${domain}.\n\nÀ propos des descriptions - les mots entre \"<>\" signifient des éléments OBLIGATOIRES, et\nles mots entre \"[]\" signalent les éléments FACULTATIFS.  Ne pas inclure les \"<>\" ou\n\"[]\" quand vous utilisez les commandes.\n\nLes commandes suivantes sont valides :\n\n    ${commands}\n\nLes questions et inquiétudes à l’adresse d’une personne doivent être envoyés à :\n\n    ${administrator}",

I guess that is because of <> instead of &lt;&gt;?

Change 685938 merged by jenkins-bot:

[integration/config@master] Zuul: [operations/software/mailman-templates] Add CI of debian-glue

https://gerrit.wikimedia.org/r/685938

The config change adds:

gate-and-submit-l10n:
  - debian-glue

The debian-glue job only runs for changes affecting a file in the ./debian directory, it is otherwise not triggered. Since L10n-bot only touches ./i18n/* (example), the job is never run, the gate-and-submit-l10n pipeline does not run any job and the change is left idling waiting for job success that will never come.

Ugh, that's not great for native Debian packages which should run the build process on every commit. I guess I can just add a simple tox wrapper to run the tests.

Other repositories have the job mediawiki-i18n-check-docker which run the diff through a large sed that attempts to detect HTML. So I guess we should use that job and drop debian-glue.

That's not useful here, these aren't HTML, it's all plain text.

l10n-bot-watchers rights are still missing, so we can't even override Jenkins currently. Docs: https://www.mediawiki.org/wiki/Gerrit/L10n-bot

abi_ added a subscriber: thcipriani.

We have the necessary permissions now. Exports are working properly. Resolving this task.

Thanks @thcipriani for your help!