Page MenuHomePhabricator

Take people to the precise location of the talk page activity they are being notified about
Closed, ResolvedPublic

Description

This task involves the work of ensuring that whenever people click on a notification that appears within Echo's "alerts" or "notices" they are taken to the precise location on the page where the content they are being notified about exists.

Doing what's described above requires extending the work that's been done in T265268 and T281471, as @matmarex described in T253082#7046820.

Notifications to "map"

Notification typeTicket
Mention notificationsT253082
Own user talk page comment notificationsT281590
Topic Subscription new comment notifications(already done in the initial version)

Open questions

  • What other notifications need to be "mapped"?

Done

  • All ===Open questions are answered
  • All of the notification types listed in the ===Notifications to "map" section have been "mapped"
  • create a post for Tech News @Whatamidoing-WMF

Related Objects

Event Timeline

matmarex added a project: User-notice.
matmarex added a subscriber: Whatamidoing-WMF.

A few changes we're making here affects everyone's experience (not only users of the beta topic subscriptions), they should probably be announced in Tech News. I'm not sure how to phrase it, but they all seem closely related to me, so I'd report them all in one bullet point. First draft:

"When you are mentioned or receive a message on your user talk page, clicking on the notification (or on the orange user talk page message banner) will now highlight the added comment, rather than only scroll to the section it was added in."

I'm not sure how to phrase it, but they all seem closely related to me, so I'd report them all in one bullet point.

If it’s just these two changes, and they go live the same week, I agree.

First draft:

"When you are mentioned or receive a message on your user talk page, clicking on the notification (or on the orange user talk page message banner) will now highlight the added comment, rather than only scroll to the section it was added in."

It seems a bit too complicated for me. (Tech News aims to use as simple English as possible so that people with poor English knowledge also get notified about important tech changes.) What about the following?

“You can receive notifications when someone leaves a comment on user talk page or mentions you in a talk page comment. The notification link will now bring you to the comment and highlight it. Previously it brought you to the top of the section that contained the comment.”

(Note: while user talk page notifications are sent about all edits, not just comments, I intentionally wrote “content”, as I’m pretty sure the change is only about comments—you can’t bring the user to the comment if there’s no single new comment to begin with.)

@Tacsipacsi Sounds okay to me, thanks. (Although I usually dislike the over-simplified language used in Tech News, sometimes people go too far in trying to keep it simple and remove all of the information from it.)

Re: Tech News - Thanks for the draft! Much appreciated.
Should it be included in this week's edition (to be delivered on Monday), or should I wait for you to tell me when it is ready for inclusion?

Re: Tech News - Thanks for the draft! Much appreciated.
Should it be included in this week's edition (to be delivered on Monday), or should I wait for you to tell me when it is ready for inclusion?

@Quiddity, good question. Can you please assume this update should not be included in the version of Tech/News planned for this upcoming Monday, 27-Sep? Should this change, I will comment here and ping you in Slack tomorrow morning (Pacific Time). [i]


i. I assume last minute inclusion decisions can be made up until Friday morning Pacific Time based on the information on meta:Tech/News/For contributors#When is the work done?. Although, if this would be disruptive to y'all, please let me know!

Re: Tech News - Thanks for the draft! Much appreciated.
Should it be included in this week's edition (to be delivered on Monday), or should I wait for you to tell me when it is ready for inclusion?

@Quiddity, good question. Can you please assume this update should not be included in the version of Tech/News planned for this upcoming Monday, 27-Sep? Should this change, I will comment here and ping you in Slack tomorrow morning (Pacific Time). [i]

UPDATE
@Quiddity: if possible, it would be great for this change to be included in Monday's (27-Sep) Tech/News. I've updated the page accordingly: https://w.wiki/47jC.

Please let us know if we've missed the cutoff. Thank you for being patient with us and thank you @Tacsipacsi for the copy...I think the language simply and effectively communicates what's changing.

ppelberg claimed this task.