Right now the Minerva and MobileFrontend repositories run Selenium tests that inconsistently begin on the desktop domain when run via Jenkins as part of Gerrit code review and the mobile domain when they run in the daily jobs.
This creates a lot of unnecessary confusion and means each test has to be written for both environments.
For consistency, the tests should always run beginning on the desktop domain.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| selenium: Run tests from desktop site | mediawiki/skins/MinervaNeue | master | +3 -22 |
Swich from desktop to mobile happened in 9e92bdbc5071af1d1cda59a0922de59bb9e0a7a7 (503033).
Yeh that patch worked around this issue for Minerva.
This problem we have in Minerva, is that we want to run browser tests there on a MediaWiki install without MobileFrontend or Vector installed. The current setup prohibits skins other than Vector from running browser tests. Presumably it should be possible for Minerva to use a wiki with Minerva installed as the default skin. e.g. $wgDefaultSkin = 'minerva';
Given all browser tests run together however I am not sure how best to do this from an architecture point of view.
For MobileFrontend, this change should be more straightforward, switching to desktop should be part of each integration test, so perhaps we could start there?
Change 686630 had a related patch set uploaded (by Zfilipin; author: Zfilipin):
[mediawiki/skins/MinervaNeue@master] WIP Minerva and MobileFrontend should run Selenium tests from desktop site
@Jdlrobson: @Edtadros and I ran MinervaNeue tests targeting desktop site. All tests passed except the new one I wrote recently. I've fixed the test in 686630. The patch also switches MinervaNeue selenium-daily NPM script from targeting mobile domain to targeting desktop site. (That script starts selenium-daily-beta-Minerva Jenkins job.) I don't think there's anything else left to do in MinervaNeue.
I've looked in MobileFrontend, and in both places that decide what URL to target, it's already set to desktop. I don't think there's anything to do there.
- MobileFrontend: recipients: jrobson@wikimedia.org qa-alerts@lists.wikimedia.org # @Jdlrobson repository: mediawiki/extensions/MobileFrontend site: en.wikipedia
"scripts": { "selenium-daily": "npm run selenium-test", "selenium-test": "wdio tests/selenium/wdio.conf.js", },
Change 686630 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] selenium: Run tests from desktop site