Page MenuHomePhabricator
Create Task
Maniphest T282065

PageImages should be < 300kb for Whatsapp share support
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
May 5 2021, 10:45 PM
Tags
Referenced Files
F34824519: IMG_3813.jpg
Dec 3 2021, 10:21 PM
F34789424: Screen Shot 2021-11-29 at 8.54.58 AM.png
Nov 29 2021, 4:57 PM
F34762371: RPReplay_Final1637618565 3.mov.gif
Nov 22 2021, 10:18 PM
F34762369: RPReplay_Final1637618565.mov.gif
Nov 22 2021, 10:18 PM
F34762367: RPReplay_Final1637618565 2.mov.gif
Nov 22 2021, 10:15 PM
F34743419: image.png
Nov 12 2021, 3:41 PM
F34740781: Screen Shot 2021-11-10 at 2.54.15 PM.png
Nov 10 2021, 1:55 PM
F34740784: Screen Shot 2021-11-10 at 2.54.33 PM.png
Nov 10 2021, 1:55 PM
View All 9 Files
Subscribers
Aklapper
• alexhollender_WMF
eamedina
Edtadros
Jdlrobson
Jdrewniak
ovasileva
View All 9 Subscribers

Description

Per T157145#6858470, when page image thumbnails are greater than 300kb they will be ignored by Whatsapp when a Wikipedia article is shared appearing like so:

image.png (879×1 px, 482 KB)

PageImages should therefore consider the size of the thumbnail when choosing a page image or adding the og:image tag to the page.

QA steps

  1. Go to whatsapp
  2. Paste a link to a wikipedia article that has an image

Expected: image preview should appear within whatsapp

https://phabricator.wikimedia.org/T282065#7521993
https://phabricator.wikimedia.org/T282065#7522011

QA Results - Beta

ACStatusDetails
1❌T282065#7521993

QA Results - Prod

ACStatusDetails
1❌ ✅T282065#7522011 T282065#7547387

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Output multiple og:image with widths 1200/800/640mediawiki/extensions/PageImagesmaster+12 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 5 2021, 10:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2021, 10:45 PM
Jdlrobson mentioned this in T157145: Twitter cards don't work for any projects besides Wikidata.May 5 2021, 10:46 PM
ovasileva subscribed.May 6 2021, 8:53 AM
Redmin subscribed.May 7 2021, 10:13 AM
• AMooney edited projects, added Web-Team-Backlog-Archived; removed Platform Engineering.May 11 2021, 9:11 PM
Jdlrobson moved this task from Incoming to Tracking on the Web-Team-Backlog-Archived board.May 14 2021, 4:27 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Tracking); removed Web-Team-Backlog-Archived.
Jdlrobson added a project: Product-Infrastructure-Team-Backlog-Deprecated.
Jdlrobson added a subscriber: • sdkim.

@sdkim @ovasileva this task is pretty important I think for our product infrastructure but doesn't seem a good fit for the web team given our code stewardship review request for PageImages and inexperience with the extension.

MSantos moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.Jun 14 2021, 11:29 AM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog-Archived (Tracking) board.Sep 8 2021, 3:25 PM
ovasileva moved this task from Untag to Move to Backlog on the Web-Team-Backlog-Archived (Tracking) board.Sep 22 2021, 3:30 PM
gerritbot added a comment.Oct 26 2021, 10:50 AM

Change 734584 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/PageImages@master] Output multiple og:image with widths 1200/800/640

https://gerrit.wikimedia.org/r/734584

gerritbot added a project: Patch-For-Review.Oct 26 2021, 10:50 AM
gerritbot added a comment.Oct 26 2021, 8:21 PM

Change 734584 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Output multiple og:image with widths 1200/800/640

https://gerrit.wikimedia.org/r/734584

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Oct 26 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 26 2021, 9:10 PM
Jdlrobson edited projects, added Patch-For-Review, Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived (Tracking).Oct 26 2021, 9:14 PM
Jdlrobson added a subscriber: • alexhollender_WMF.

FYI @ovasileva @alexhollender

Jdlrobson assigned this task to ovasileva.Oct 26 2021, 9:15 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
• alexhollender_WMF awarded a token.Oct 27 2021, 2:12 PM
Jdlrobson added a comment.Oct 27 2021, 2:21 PM

During testing we noticed this change improves things but doesn't fix all pages. https://en.wikipedia.beta.wmflabs.org/wiki/Dog for example is still too small even with the lower resolution

ovasileva moved this task from Ready for Signoff to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Oct 27 2021, 4:38 PM
LGoto triaged this task as Medium priority.Oct 28 2021, 5:10 PM
eamedina subscribed.Nov 4 2021, 3:29 PM
ovasileva moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Nov 8 2021, 10:43 AM
ovasileva added a comment.Nov 10 2021, 1:55 PM

@Jdlrobson - not sure what happened, but I think this has regressed:
Last Thursday:

Screen Shot 2021-11-10 at 2.54.15 PM.png (160×595 px, 51 KB)

Today:
Screen Shot 2021-11-10 at 2.54.33 PM.png (83×557 px, 28 KB)

ovasileva moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Nov 10 2021, 1:55 PM
Jdlrobson added a comment.Nov 10 2021, 4:07 PM

Could you please paste the URL here, so I can debug it in https://developers.facebook.com/tools/debug/ ?

ovasileva added a comment.Nov 11 2021, 10:38 AM
In T282065#7496284, @Jdlrobson wrote:

Could you please paste the URL here, so I can debug it in https://developers.facebook.com/tools/debug/ ?

This is the url I've been testing with https://he.wikipedia.org/wiki/%D7%90%D7%A1%D7%99%D7%94_%D7%94%D7%A7%D7%98%D7%A0%D7%94, but I also cannot get the change to show with any other url either on any wiki

Jdlrobson moved this task from Needs More Work to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Nov 12 2021, 3:41 PM

Could be a problem with cached HTML but that URL is working for me:

image.png (2×1 px, 911 KB)

Want to try again?

ovasileva removed ovasileva as the assignee of this task.Nov 16 2021, 6:10 PM
ovasileva assigned this task to Edtadros.
ovasileva updated the task description. (Show Details)
QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 5:42 PM
QutieBot moved this task from Inbox to Edward on the QTE-TestingOverview board.
Edtadros added a comment.Nov 22 2021, 10:15 PM

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Go to whatsapp
❌ AC1: Paste a link to a wikipedia article that has an image

I tried this for https://en.wikipedia.beta.wmflabs.org/wiki/Dog and the image would not come up.

RPReplay_Final1637618565 2.mov.gif (1×888 px, 2 MB)

Edtadros moved this task from QA in Prod to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Nov 22 2021, 10:18 PM

Test Result - Prod

Status: ❌ FAIL
Environment: enwiki, hewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Go to whatsapp
❌ AC1: Paste a link to a wikipedia article that has an image

I tried this for this link and the image appeared. But when I tried it with this link, and the image would not come appear.

RPReplay_Final1637618565.mov.gif (1×888 px, 1 MB)

RPReplay_Final1637618565 3.mov.gif (1×888 px, 2 MB)

Edtadros removed Edtadros as the assignee of this task.Nov 22 2021, 10:24 PM
Edtadros updated the task description. (Show Details)
Edtadros subscribed.
LGoto assigned this task to Jdrewniak.Nov 23 2021, 6:05 PM
Jdlrobson added a comment.Nov 29 2021, 4:57 PM

FWIW I can see previews for both the Dog and Nina Simone article in T282065#7522011 . @Edtadros can you re-check these?

If it wasn't showing before but is showing now, it was likely not updated Meta/Facebook/Whatsapp-side. Note the tool https://developers.facebook.com/tools/debug/ tells you when the image was scraped.
The Dog article was scraped in October prior to this change

Screen Shot 2021-11-29 at 8.54.58 AM.png (278×1 px, 54 KB)

so I clicked scrape again to make that work better.

Nina was scraped on Nov 5th. https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FNina_Simone
I have now clicked "scrape again".

However, it's possible Whatsapp has its own scraper separate from this with similar cached pages.

FWIW I don't think we should QA further without understanding the Facebook code and I think this should be untagged with the board. I think the QA so far is sufficient. As detailed earlier this bug is not fixed, it's just improved.

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Nov 29 2021, 4:57 PM
Jdlrobson moved this task from Needs More Work to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: Jdrewniak.
Edtadros reassigned this task from Edtadros to ovasileva.Dec 3 2021, 10:21 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: iOS 15
Browser: NA
Device: iPhone
Emulated Device: NA

Test Artifact(s):

QA Steps

Go to whatsapp
✅ AC1: Paste a link to a wikipedia article that has an image

Thanks @Jdlrobson for working with me on this one.

IMG_3813.jpg (2×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Dec 3 2021, 10:22 PM
ovasileva closed this task as Resolved.Dec 6 2021, 10:17 AM

Yay, looks good

simon04 added a subtask: T295521: Duplicate og:image on Wikipedia and Wikidata (There are too many faces of Tom Hanks).Jan 6 2024, 8:48 PM
Krinkle closed subtask T295521: Duplicate og:image on Wikipedia and Wikidata (There are too many faces of Tom Hanks) as Resolved.Aug 20 2025, 1:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits