Page MenuHomePhabricator

Language selector not visible on Hungarian Wikipedia in modern Vector with Javascript enabled
Closed, ResolvedPublic

Description

E.g. https://hu.wikipedia.org/wiki/2231_Durrell?useskin=vector&useskinversion=2

hu.wikipedia.org_wiki_2231_Durrell_useskin=vector&useskinversion=2.png (949×1 px, 207 KB)

Almost certainly caused by a site script that improves how FlagRev information is displayed. (T197912: Option to have FlaggedRevs rating box as an indicator is a proposal to upstream that improvement into the extension.)

Event Timeline

When logged out, it’s not there, not even in safe mode; it’s just missing from the DOM tree. When logged in, it’s there but the FlaggedRevs box overlaps it.

I set the opacity of the FlaggedRevs box to 50% to demonstrate this:

  • Logged out:
    Screenshot_2021-05-07 2231 Durrell – Wikipédia.png (38×607 px, 4 KB)
  • Logged in:
    Screenshot_2021-05-07 2231 Durrell – Wikipédia(1).png (38×607 px, 6 KB)

I think we can just put the FlaggedRevs box in the below row, in the indicator box, on modern Vector, which will fix it for logged-in users. I’ll do this FlaggedRevs repositioning, and leave this ticket for fixing the logged-out case.

Tacsipacsi claimed this task.

Oh, I just noticed that logged-out users still get the language links in the sidebar (which is collapsed by default – doesn’t seem like a very good UX decision…). So this bug report is actually only about logged-in users, which I hope to have fixed (JS, CSS).