Page MenuHomePhabricator

Create and implement new homepage template
Closed, ResolvedPublic

Description

We need a new homepage template based on the new base template (T282113) which incorporates the carousel (T282114) and implements the remaining functionality.

Acceptance criteria

  • Logged out users see this template instead of a logged out version of the current homepage.
  • Hovering over the information button displays the additional help text.
  • Successful logins send users to the existing homepage in the logged in state.
  • Users who are already logged in should be redirected through to My Library without seeing this page.

Event Timeline

Samwalton9 triaged this task as Medium priority.May 6 2021, 12:50 PM
Samwalton9 created this task.
Samwalton9 updated the task description. (Show Details)

Thanks! Initial thoughts from testing on:

Google Chrome, 2560x1440

image.png (1×2 px, 116 KB)

  • The content leaves a substantial gap to the right hand side - I feel like the 'whitespace' either side of the content should be equal.
  • For some reason I have a horizontal scroll bar. There's no visible additional content to the right, just white.
  • I think it would be best, for now, if the login button sent users to the existing homepage (clarified the acceptance criteria). Going straight to My Library is going to be confusing at the moment.

Mobile (Android): Google Chrome, 1080x1920

Screenshot_20210525_134438_com.android.chrome.jpg (1×1 px, 130 KB)

Screenshot_20210525_134606_com.android.chrome.jpg (1×1 px, 131 KB)

  • The 'Meet this criteria...' text flows off the screen to the right.
    • It actually looks like I again have the ability to scroll right, with the last letter of 'access' disappearing into the white border.
  • The 'login via Wikipedia' button looks like it needs some padding below it.

Do you think you could do a quick translation of the homepage elements into Spanish so we can test translation?

Removed the acceptance criteria item about ineligible users. We'll handle that case in the My Library view. For now, send ineligible users through too.

Do you think you could do a quick translation of the homepage elements into Spanish so we can test translation?

Sure! I'll send you a screenshot when I have it!

This is a translated version to Spanish. Note that some of the new strings won't be available for translation until we get this PR merged

Screen Shot 2021-05-25 at 18.30.12.png (435×1 px, 90 KB)

Looks good!

Looks like the scroll-bar issue is fixed on mobile, though it's still present on desktop. There's now a white bar down the right-hand side on mobile though.

jsn.sherman added a subscriber: jsn.sherman.

Per back channel discussion, it looks like everybody is happy with this. Merged!