Page MenuHomePhabricator

Disable compact language link setting does not apply to modern Vector
Closed, ResolvedPublic

Description

Background

With the introduction on the new language switcher for the modern version of the vector skin, the preference setting which allows compact language links to appear/disappear is not longer relevant

Acceptance criteria

  • When legacy vector is disabled, disable the setting for compact language links

QA steps

QA Results - Beta

ACStatusDetails
1T282149#7163729

QA Results - Beta

ACStatusDetails
1T282149#7168404
2T282149#7168404

QA Results - Prod

ACStatusDetails
1T282149#7174101
2T282149#7174101

Event Timeline

ovasileva triaged this task as Medium priority.May 6 2021, 2:46 PM

Should we repurpose this configuration to apply to new Vector as well?

@sgrabarczuk informed me that there are gadgets that are popular wiht community members that are incompatible with the compact language feature
e.g. https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-SidebarTranslate.js

Should we repurpose this configuration to apply to new Vector as well?

@sgrabarczuk informed me that there are gadgets that are popular wiht community members that are incompatible with the compact language feature
e.g. https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-SidebarTranslate.js

@Pginer-WMF - any thoughts on this? Do we have any idea on what the usage is, how many people opt out of compact language links?

Should we repurpose this configuration to apply to new Vector as well?

@sgrabarczuk informed me that there are gadgets that are popular wiht community members that are incompatible with the compact language feature
e.g. https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-SidebarTranslate.js

Huh? I actually remember fixing that. Did it get broken again?

Should we repurpose this configuration to apply to new Vector as well?

@sgrabarczuk informed me that there are gadgets that are popular wiht community members that are incompatible with the compact language feature
e.g. https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-SidebarTranslate.js

@Pginer-WMF - any thoughts on this? Do we have any idea on what the usage is, how many people opt out of compact language links?

Compact language links was gradually enabled. First as a beta feature and when it became a standard feature (on February 28, 2018) it was enabled automatically only for new users. For users with an account created before that date, only those who explicitly enabled the beta feature got the feature enabled by default.

With that context in mind, Amir compiled some numbers from English Wikipedia:

  • From those getting compact language links enabled by default (accounts created after February 28, 2018) a very small percentage explicitly disabled the feature: only 3772 users out of 8,489,351 (0.04%) explicitly disabled the feature.
  • From users with an account created before the enablement of the feature there is a significant number of users (1,006,740) with the feature disabled. We don't know how many even tried the feature, but probably most are not explicit disablements (i.e., they have not enabled it in the first place).

Should we repurpose this configuration to apply to new Vector as well?

@sgrabarczuk informed me that there are gadgets that are popular wiht community members that are incompatible with the compact language feature
e.g. https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-SidebarTranslate.js

Huh? I actually remember fixing that. Did it get broken again?

Oh tell me more! :) did you get this working inside the search dialog?

Change 691233 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Default state of ULSCompactLanguageLinksBetaFeature should be false

https://gerrit.wikimedia.org/r/691233

Change 691234 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Restore compact languages button user preference

https://gerrit.wikimedia.org/r/691234

Change 691235 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Allow disabling of the new compact languages button

https://gerrit.wikimedia.org/r/691235

@Rileych - Would it be possible for us to request a review for this within the next 2 weeks or so?

Jdlrobson renamed this task from Disable compact language link setting when not in legacy vector to Disable compact language link setting does not apply to modern Vector.May 27 2021, 5:08 PM

@Nikerabbit

@ovasileva Niklas is on it and we'll be able to have this completed within the requested time frame.

Change 691233 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Default state of ULSCompactLanguageLinksBetaFeature should be false

https://gerrit.wikimedia.org/r/691233

@Nikerabbit just in case I added confusion with the above patch that got merged, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/691234 is the patch I was hoping to get a review for.

Change 691234 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Restore compact languages button user preference

https://gerrit.wikimedia.org/r/691234

Change 691235 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Allow disabling of the new compact languages button

https://gerrit.wikimedia.org/r/691235

Edtadros subscribed.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ AC1: When legacy vector is disabled, disable the setting for compact language links

Enabling or disabling Legacy Vector had no impact on the ability to select the compact language list check box. I wasn't sure that the checkbox on the bottom was what was referred to in the task description but this tells me it is.

Screen Shot 2021-06-19 at 11.45.18 AM.png (1×852 px, 184 KB)

Jdlrobson updated the task description. (Show Details)

Added some clearer QA steps.

Test Result - Beta

Status:
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Make sure you are a logged in user looking at modern Vector (check Special:Preferences) and that "Use a compact language list, with languages relevant to you." is checked.
Go to https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein, the language button when clicked should open a dialog

Screen Recording 2021-06-21 at 7.07.13 PM.mov.gif (966×1 px, 459 KB)

✅ AC2: Go to Special:Preferences and uncheck "Use a compact language list, with languages relevant to you.".
Go to https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein, the language button when clicked should open a dropdown list without the ability to search

Screen Recording 2021-06-21 at 7.08.37 PM.mov.gif (966×1 px, 406 KB)

Test Result - Prod

Status:
Environment: testwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Make sure you are a logged in user looking at modern Vector (check Special:Preferences) and that "Use a compact language list, with languages relevant to you." is checked.
Go to https://test.wikipedia.org/w/index.php?title=Carcharhinus_melanopterus&languageinheader=true, the language button when clicked should open a dialog

Screen Recording 2021-06-23 at 6.08.56 PM.mov.gif (840×1 px, 510 KB)

✅ AC2: Go to Special:Preferences and uncheck "Use a compact language list, with languages relevant to you.".
Go to https://test.wikipedia.org/w/index.php?title=Carcharhinus_melanopterus&languageinheader=true, the language button when clicked should open a dropdown list without the ability to search

Screen Recording 2021-06-23 at 6.10.11 PM.mov.gif (840×1 px, 405 KB)