Page MenuHomePhabricator
Create Task
Maniphest T282167

Unblock Analytics Team: Drop MobileWebSearch schema
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
May 6 2021, 4:51 PM
Tags
Referenced Files
F34557628: Screen Recording 2021-07-20 at 6.00.06 AM.mov.gif
Jul 20 2021, 1:08 PM
F34519844: Screen Recording 2021-06-21 at 8.06.00 PM.mov.gif
Jun 22 2021, 3:11 AM
F34519828: Screen Recording 2021-06-21 at 7.32.14 PM.mov.gif
Jun 22 2021, 3:11 AM
F34519830: Screen Recording 2021-06-21 at 7.30.57 PM.mov.gif
Jun 22 2021, 3:11 AM
F34519836: Screen Recording 2021-06-21 at 7.27.49 PM.mov.gif
Jun 22 2021, 3:11 AM
F34519834: Screen Recording 2021-06-21 at 7.36.34 PM.mov.gif
Jun 22 2021, 3:11 AM
Subscribers
Aklapper
cjming
Edtadros
Jdlrobson
MNeisler
mpopov
Ottomata
ovasileva
Tokens
"Love" token, awarded by Ottomata.

Description

Following a conversation between @ovasileva @mpopov @Jdlrobson @Ottomata and @MNeisler to save analytics the effort of migrating the MobileWebSearch to the new EventLogging platform, given we are not using the data, we will remove the code. This will save the analytics team from wasting unnecessary time migrating this schema.

TODO

  • Disable search schema via a config change to MFSchemaSearchSampleRate from hooks and JSON
  • Remove all traces of MFSchemaSearchSampleRate from our codebase
  • Remove src/mobile.init/eventLogging/schemaMobileWebSearch.js
  • Remove src/mobile.startup/search/MobileWebSearchLogger.js and associated test
  • Remove wire up code in src/mobile.init/mobile.init.js
  • Remove "MobileWebSearch": 12054448 from extension.json

Sign off steps

  • Make sure a task exists about using the new wvui search widget on mobile and noting that doing this will allow us to instrument the search again.

QA Results - Beta

ACStatusDetails
1✅T282167#7168433

QA Results - Prod

ACStatusDetails
1✅T282167#7224358

Details

SubjectRepoBranchLines +/-
Remove emitted events from SearchOverlaymediawiki/extensions/MobileFrontendmaster+3 -44
Remove MobileWebSearch schemamediawiki/extensions/MobileFrontendmaster+6 -291
Remove SearchLoggermediawiki/skins/MinervaNeuemaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 6 2021, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2021, 4:51 PM
ovasileva triaged this task as Medium priority.May 6 2021, 4:58 PM
Ottomata awarded a token.May 6 2021, 6:12 PM
Ottomata added a parent task: T238230: Decommission EventLogging backend components by migrating to MEP.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 7 2021, 3:12 PM
Jdlrobson renamed this task from Drop MobileWebSearch schema to Unblock Analytics Team: Drop MobileWebSearch schema.May 25 2021, 7:19 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from Medium to High.May 26 2021, 5:32 PM
LGoto set the point value for this task to 3.Jun 1 2021, 5:16 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming claimed this task.Jun 4 2021, 5:52 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 8 2021, 1:56 AM

Change 698651 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/MobileFrontend@master] Remove MobileWebSearch schema

https://gerrit.wikimedia.org/r/698651

gerritbot added a project: Patch-For-Review.Jun 8 2021, 1:56 AM
gerritbot added a comment.Jun 10 2021, 9:50 PM

Change 699310 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/MinervaNeue@master] Remove SearchLogger

https://gerrit.wikimedia.org/r/699310

cjming removed cjming as the assignee of this task.Jun 10 2021, 10:40 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming subscribed.
gerritbot added a comment.Jun 10 2021, 11:32 PM

Change 699310 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove SearchLogger

https://gerrit.wikimedia.org/r/699310

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 11 2021, 12:00 AM
gerritbot added a comment.Jun 11 2021, 12:03 AM

Change 698651 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove MobileWebSearch schema

https://gerrit.wikimedia.org/r/698651

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 12:10 AM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 11 2021, 12:33 AM

@cjming I think we can remove the events emitted by the SearchOverlay e.g. search-show, search-results, search-start, search-click as well.

gerritbot added a comment.Jun 11 2021, 7:46 PM

Change 699465 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/MobileFrontend@master] Remove emitted events from SearchOverlay

https://gerrit.wikimedia.org/r/699465

gerritbot added a project: Patch-For-Review.Jun 11 2021, 7:46 PM
Jdlrobson assigned this task to Edtadros.Jun 11 2021, 9:16 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 11 2021, 9:32 PM

Change 699465 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove emitted events from SearchOverlay

https://gerrit.wikimedia.org/r/699465

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 10:10 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Jun 19 2021, 7:05 PM
Edtadros subscribed.

@Jdlrobson I'm not sure what is intended to be testable here. The signoff steps call out that a task should exist, but I couldn't find one other than this one. I went through some of the gerrit links and saw that some of the items in "ToDo" were removed, but I'm not convinced that is comprehensive enough for validating that all traces are removed. That's better performed as a unit test by someone familiar with the codebase. Let me know your thoughts on how you would like me to proceed.

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 21 2021, 4:59 PM

@Edtadros could you do a smoke test of the search feature on mobile, and just confirm you can use it's basic features and that no JavaScript errors show up in the developer console while using the feature ? e.g. search within page, click search result, cancel search

Edtadros reassigned this task from Edtadros to Jdlrobson.EditedJun 22 2021, 3:11 AM

Test Result - Beta

Status: ✅ Pass
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Smoke test search feature in mobile.
Functionally the following work, so this is passed: Searching, Search within Pages, clicking a search item, Cancelling Search, Clearing search.

Screen Recording 2021-06-21 at 7.27.49 PM.mov.gif (902×762 px, 1 MB)

@Jdlrobson There are three behaviors I want to bring to your attention. If you are okay with these then I'll pass it./
1) When you X out of the search, not to clear the search, and don't navigate away, if you click back in the search, your previous search string is still displayed. I suspect this is as designed but I wanted to be sure.//
Screen Recording 2021-06-21 at 7.36.34 PM.mov.gif (902×762 px, 1 MB)

2) When you click on the search icon to the left of the "Search within pages", it will momentarily display the page you were on and then navigate to the search page. Clicking on "Search within pages" does not do that, it goes straight to search as expected.

Screen Recording 2021-06-21 at 7.32.14 PM.mov.gif (902×762 px, 853 KB)

3) When you click on a watch star, some text is displayed, if you click on multiple watch stars the text remains displayed as shown below:

Screen Recording 2021-06-21 at 7.30.57 PM.mov.gif (902×762 px, 634 KB)

Screen Recording 2021-06-21 at 8.06.00 PM.mov.gif (902×762 px, 846 KB)

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 24 2021, 5:13 PM

The watchstar is unrelated so this can be considered a pass. We're looking to get rid of that code at some point, so I won't raise a new issue.

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 30 2021, 4:43 PM
Edtadros reassigned this task from Edtadros to ovasileva.Jul 20 2021, 1:08 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Test Result - Prod

Status: ✅ Pass
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Smoke test search feature in mobile.
Functionally the following work, so this is passed:
Searching, Search within Pages, clicking a search item, Canceling Search, Clearing search.

Screen Recording 2021-07-20 at 6.00.06 AM.mov.gif (1×988 px, 3 MB)

Edtadros updated the task description. (Show Details)Jul 20 2021, 1:08 PM
Edtadros updated the task description. (Show Details)
ovasileva closed this task as Resolved.Jul 22 2021, 8:53 PM

Looks good!

cchen mentioned this in T305228: Rebuild MobileWebSearch schema.Apr 1 2022, 9:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL