Page MenuHomePhabricator
Create Task
Maniphest T282194

[mobile] Add link: clicking on article elements triggers "Unrecognized symbolic name: alien"
Closed, ResolvedPublic
Actions

Description

The issue seems to be specific to mobile.

  1. On mobile open an article (an article should have an image, external links, and references) in add link suggestion mode.
  2. Click on any of the elements - an external link, an image etc. The Console will display
Uncaught Error: Unrecognized symbolic name: alien
at VeUiContextItemFactory.ve.ui.ContextItemFactory.isEmbeddable                 
at VeUiMobileContext.ve.ui.LinearContext.getRelatedSourcesFromModels

Notes:

  • On mobile, when external links are clicked, a slide-up Citation is shown. When an image is clicked, it opens in a full view.
  • the Console errors do not affect user experience

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (63e87da8e)mediawiki/extensions/VisualEditormaster+1 -1
Call contextItemFactory.lookup, not contextItemFactory.registry.lookupVisualEditor/VisualEditormaster+1 -1
Check if alien context item is registered before usingVisualEditor/VisualEditormaster+1 -1
Update VE core submodule to master (0c024f431)mediawiki/extensions/VisualEditormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 6 2021, 10:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2021, 10:53 PM
• mewoph added a comment.May 6 2021, 11:28 PM

Hi @Etonkovidova which environment is this from? With changes for T281434: Add link: VE shortcut opens a regular link inspector overlapping add link context item context items for elements other than link recommendations should not be invoked.

kostajh triaged this task as Medium priority.May 7 2021, 7:29 AM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.May 7 2021, 7:37 AM
kostajh moved this task from Backlog to May 10 - May 14 on the Add-Link board.May 10 2021, 1:23 PM
kostajh claimed this task.May 11 2021, 1:26 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 11 2021, 1:28 PM
gerritbot added a comment.May 11 2021, 2:12 PM

Change 689076 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[VisualEditor/VisualEditor@master] Check if alien context item is registered before using

https://gerrit.wikimedia.org/r/689076

gerritbot added a project: Patch-For-Review.May 11 2021, 2:12 PM
gerritbot added a comment.May 12 2021, 4:30 PM

Change 689076 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Check if alien context item is registered before using

https://gerrit.wikimedia.org/r/689076

kostajh moved this task from May 10 - May 14 to Done / QA on the Add-Link board.May 12 2021, 4:31 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot removed a project: Patch-For-Review.May 12 2021, 5:10 PM
Krinkle added a project: VisualEditor.May 12 2021, 7:44 PM
Krinkle merged a task: T282200: Error: Unrecognized symbolic name: alien at VeUiMobileContext..
Krinkle added subscribers: Jdlrobson, Masumrezarock100.
Etonkovidova added a comment.May 12 2021, 9:30 PM
In T282194#7068161, @mewoph wrote:

Hi @Etonkovidova which environment is this from? With changes for T281434: Add link: VE shortcut opens a regular link inspector overlapping add link context item context items for elements other than link recommendations should not be invoked.

I was checking in betalabs (with Chrome mobile emulator).

Testing in betalabs:

No Console errors when the following items are clicked
- ✅ external links
- ✅internal red links
- ✅ internal blue links
Console errors when the following items are clicked
- clicking on an image, e.g. class="ve-ce-mwBlockImageNode-thumbimage"
- clicking on the reference link e.g. <span class="mw-reflink-text">[10]</span>
- clicking on template red links
kostajh added a comment.May 12 2021, 9:31 PM
In T282194#7083836, @Etonkovidova wrote:
In T282194#7068161, @mewoph wrote:

Hi @Etonkovidova which environment is this from? With changes for T281434: Add link: VE shortcut opens a regular link inspector overlapping add link context item context items for elements other than link recommendations should not be invoked.

I was checking in betalabs (with Chrome mobile emulator).

Testing in betalabs:

No Console errors when the following items are clicked
- ✅ external links
- ✅internal red links
- ✅ internal blue links
Console errors when the following items are clicked
- clicking on an image, e.g. class="ve-ce-mwBlockImageNode-thumbimage"
- clicking on the reference link e.g. <span class="mw-reflink-text">[10]</span>
- clicking on template red links

you're still seeing the console errors in betalabs?

Etonkovidova added a comment.May 12 2021, 9:39 PM
In T282194#7083837, @kostajh wrote:
Console errors when the following items are clicked
- clicking on an image, e.g. class="ve-ce-mwBlockImageNode-thumbimage"
- clicking on the reference link e.g. <span class="mw-reflink-text">[10]</span>
- clicking on template red links

you're still seeing the console errors in betalabs?

Yes, just to clarify - the errors displayed in the Console for Chrome mobile emulator on enwiki betalabs.

Screen Shot 2021-05-12 at 9.52.17 AM.png (1×2 px, 370 KB)

kostajh moved this task from QA to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.May 12 2021, 9:42 PM
kostajh moved this task from Done / QA to May 10 - May 14 on the Add-Link board.
gerritbot added a comment.May 18 2021, 12:35 AM

Change 692457 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0c024f431)

https://gerrit.wikimedia.org/r/692457

gerritbot added a project: Patch-For-Review.May 18 2021, 12:35 AM
gerritbot added a comment.May 21 2021, 3:40 PM

Change 692457 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0c024f431)

https://gerrit.wikimedia.org/r/692457

Maintenance_bot removed a project: Patch-For-Review.May 21 2021, 4:10 PM
gerritbot added a comment.May 24 2021, 8:33 PM

Change 693587 had a related patch set uploaded (by Bartosz Dziewoński; author: Divec):

[VisualEditor/VisualEditor@master] Call contextItemFactory.lookup, not contextItemFactory.registry.lookup

https://gerrit.wikimedia.org/r/693587

gerritbot added a project: Patch-For-Review.May 24 2021, 8:33 PM
gerritbot added a comment.May 24 2021, 8:37 PM

Change 693587 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Call contextItemFactory.lookup, not contextItemFactory.registry.lookup

https://gerrit.wikimedia.org/r/693587

MMiller_WMF moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2021, 9:16 PM
gerritbot added a comment.May 24 2021, 9:22 PM

Change 693956 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (63e87da8e)

https://gerrit.wikimedia.org/r/693956

matmarex added a subscriber: dchan.May 24 2021, 9:23 PM
matmarex subscribed.

The first patch had a bug that resulted in a different error (T283445). The second patch (by @dchan) should resolve this issue for real.

gerritbot added a comment.May 24 2021, 9:39 PM

Change 693956 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (63e87da8e)

https://gerrit.wikimedia.org/r/693956

kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 25 2021, 1:04 PM
In T282194#7109171, @matmarex wrote:

The first patch had a bug that resulted in a different error (T283445). The second patch (by @dchan) should resolve this issue for real.

Thank you both!

kostajh moved this task from May 10 - May 14 to Done / QA on the Add-Link board.May 25 2021, 1:04 PM
Etonkovidova updated the task description. (Show Details)Jun 18 2021, 10:59 PM
Etonkovidova closed this task as Resolved.Jun 19 2021, 2:13 AM

Checked on testwiki wmf.9 - the Console errors were not displayed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL