Language button adds itself incorrectly to new user menu on Wikidata and Wikimedia Commons
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	May 6 2021, 11:06 PM

Description

UniversalLanguageSelector has a configuration option ULSPosition which will no longer work with the planned redesign of the personal user menu we have begun building in T266536.

Screen Shot 2021-05-06 at 4.02.42 PM.png (536×524 px, 32 KB)

We will need to find a new place for this language button for these wikis, potentially revisiting the existing implementation of the language button.

Note: This is the default value for UserLanguageSelector

QA steps

Visit https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=2 or https://wikidata.beta.wmflabs.org

/wiki/Main_Page and confirm the languages option displays outside the dropdown menu.

visit Monobook and confirm languages option is in top right at far left of links

QA Results - Beta

AC	Status	Details
1	✅	T282196#7147782
2	✅	T282196#7147782

Details

Subject	Repo	Branch	Lines +/-
Use SkinTemplateNavigationUniversal for ULS button	mediawiki/extensions/UniversalLanguageSelector	master	+49 -8
Update styles for user-interface-preferences in user links menu.	mediawiki/skins/Vector	master	+25 -0
Add user-interface-preferences to personal toolbar.	mediawiki/core	master	+81 -17

Customize query in gerrit

Related Objects

Mentioned Here: T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change)
T266536: [EPIC] Consolidate user links into a single menu

Event Timeline

Jdlrobson created this task.May 6 2021, 11:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2021, 11:06 PM

@alexhollender a new problem we need to work out. Can you add this to your list?

We will need to find a new place for this language button for these wikis

The best practice on nearly all multilingual websites around is to have the language selector visible in a corner at the top, because it's the only way users can know that a different language is available at all. So the logical place would be before the bell, I suppose.

ovasileva triaged this task as High priority.May 7 2021, 9:13 AM

Seems like this is done as part of T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change)

ovasileva closed this task as a duplicate of T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change).May 7 2021, 9:21 AM

I spun this task out of that one. We didn't account for this scenario in the design so I am asking for guidance here. If we are keeping the exact same position we will need to do some significant refactoring since we are breaking up the menu and I want to avoid scope creep here.

@Jdlrobson my apologies for not being on top of this (I could have sworn we did spec this out somewhere, but alas). This is how I've been imagining it:

Commons	Wikidata	etc.
		...

Change 686663 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Use SkinTemplateNavigationUniversal for ULS button

https://gerrit.wikimedia.org/r/686663

gerritbot added a project: Patch-For-Review.May 7 2021, 5:32 PM

Cool !

@Rileych and @Nikerabbit. We're going to need a change in ULS to support this change which is https://gerrit.wikimedia.org/r/686663 - is it possible for your team to review? If it it needs to be backwards compatible with older MediaWiki's let me know and I'll add some backwards compatibility there.

This will give us:

Screen Shot 2021-05-07 at 10.32.37 AM.png (222×758 px, 21 KB)

web team would then need to take care of the styling for the new placement.

ovasileva removed • alexhollender_WMF as the assignee of this task.May 10 2021, 12:57 PM

LGoto set the point value for this task to 5.May 10 2021, 5:52 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

cjming claimed this task.May 10 2021, 6:21 PM

cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 690168 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] Add user-interface-preferences to personal toolbar.

https://gerrit.wikimedia.org/r/690168

Jdlrobson removed cjming as the assignee of this task.May 13 2021, 7:40 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson added a subscriber: cjming.

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 14 2021, 5:55 PM

cjming claimed this task.May 25 2021, 5:10 PM

ovasileva removed cjming as the assignee of this task.May 25 2021, 5:43 PM

cjming claimed this task.May 25 2021, 5:59 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 27 2021, 7:24 PM

cjming removed cjming as the assignee of this task.Jun 1 2021, 7:09 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 1 2021, 9:55 PM

Jdlrobson moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 2 2021, 7:43 PM

Change 697856 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update styles for user-interface-preferences in user links menu.

https://gerrit.wikimedia.org/r/697856

Change 690168 merged by jenkins-bot:

[mediawiki/core@master] Add user-interface-preferences to personal toolbar.

https://gerrit.wikimedia.org/r/690168

@Rileych @Nikerabbit could we get a review for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/686663 within the next 2 weeks? We would like input from language team given ULS's backwards compatibility policy. Without this change the ULS button will not show in new Vector on the beta cluster.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 2 2021, 9:00 PM

Jdlrobson updated the task description. (Show Details)Jun 5 2021, 2:11 AM

Change 697856 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update styles for user-interface-preferences in user links menu.

https://gerrit.wikimedia.org/r/697856

Change 686663 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Use SkinTemplateNavigationUniversal for ULS button

https://gerrit.wikimedia.org/r/686663

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.11; 2021-06-21); removed MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 8 2021, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2021, 8:10 AM

Jdlrobson updated the task description. (Show Details)Jun 8 2021, 1:39 PM

Jdlrobson moved this task from Blocked on Others to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson reassigned this task from Nikerabbit to Edtadros.Jun 8 2021, 5:13 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1:Visit https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=2 or https://wikidata.beta.wmflabs.org
/wiki/Main_Page and confirm the languages option displays outside the dropdown menu.

Screen Shot 2021-06-10 at 12.01.00 AM.png (311×845 px, 61 KB)

✅ AC3: visit Monobook and confirm languages option is in top right at far left of links

Screen Shot 2021-06-10 at 12.01.46 AM.png (404×1 px, 119 KB)

Edtadros updated the task description. (Show Details)Jun 10 2021, 7:05 AM

This can skip QA in production. It can't be tested there until the feature is deployed. We will do that prior to releasing the feature.

Resolving. Will have a separate task for QA for the full feature in production.

	F34489116: Screen Shot 2021-06-10 at 12.01.00 AM.png
	Jun 10 2021, 7:04 AM

	F34489118: Screen Shot 2021-06-10 at 12.01.46 AM.png
	Jun 10 2021, 7:04 AM

	F34445374: Screen Shot 2021-05-07 at 10.32.37 AM.png
	May 7 2021, 5:34 PM

	F34444322: Screen Shot 2021-05-06 at 4.02.42 PM.png
	May 6 2021, 11:06 PM

	F34445367: image.png
	May 7 2021, 5:19 PM

	F34445365: image.png
	May 7 2021, 5:19 PM

Language button adds itself incorrectly to new user menu on Wikidata and Wikimedia CommonsClosed, ResolvedPublic5 Estimated Story PointsActions