Page MenuHomePhabricator

Language button adds itself incorrectly to new user menu on Wikidata and Wikimedia Commons
Closed, ResolvedPublic5 Estimated Story Points

Description

UniversalLanguageSelector has a configuration option ULSPosition which will no longer work with the planned redesign of the personal user menu we have begun building in T266536.

We will need to find a new place for this language button for these wikis, potentially revisiting the existing implementation of the language button.

Note: This is the default value for UserLanguageSelector

QA steps

  1. Visit https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=2 or https://wikidata.beta.wmflabs.org

/wiki/Main_Page and confirm the languages option displays outside the dropdown menu.

  1. visit Monobook and confirm languages option is in top right at far left of links

QA Results - Beta

ACStatusDetails
1T282196#7147782
2T282196#7147782

Event Timeline

@alexhollender a new problem we need to work out. Can you add this to your list?

We will need to find a new place for this language button for these wikis

The best practice on nearly all multilingual websites around is to have the language selector visible in a corner at the top, because it's the only way users can know that a different language is available at all. So the logical place would be before the bell, I suppose.

I spun this task out of that one. We didn't account for this scenario in the design so I am asking for guidance here. If we are keeping the exact same position we will need to do some significant refactoring since we are breaking up the menu and I want to avoid scope creep here.

@Jdlrobson my apologies for not being on top of this (I could have sworn we did spec this out somewhere, but alas). This is how I've been imagining it:

CommonsWikidataetc.
...

Change 686663 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Use SkinTemplateNavigationUniversal for ULS button

https://gerrit.wikimedia.org/r/686663

Jdlrobson added subscribers: Rileych, Nikerabbit.

Cool !

@Rileych and @Nikerabbit. We're going to need a change in ULS to support this change which is https://gerrit.wikimedia.org/r/686663 - is it possible for your team to review? If it it needs to be backwards compatible with older MediaWiki's let me know and I'll add some backwards compatibility there.

This will give us:


web team would then need to take care of the styling for the new placement.

Change 690168 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] Add user-interface-preferences to personal toolbar.

https://gerrit.wikimedia.org/r/690168

Jdlrobson added a subscriber: cjming.

Change 697856 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update styles for user-interface-preferences in user links menu.

https://gerrit.wikimedia.org/r/697856

Change 690168 merged by jenkins-bot:

[mediawiki/core@master] Add user-interface-preferences to personal toolbar.

https://gerrit.wikimedia.org/r/690168

@Rileych @Nikerabbit could we get a review for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/686663 within the next 2 weeks? We would like input from language team given ULS's backwards compatibility policy. Without this change the ULS button will not show in new Vector on the beta cluster.

Change 697856 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update styles for user-interface-preferences in user links menu.

https://gerrit.wikimedia.org/r/697856

Change 686663 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Use SkinTemplateNavigationUniversal for ULS button

https://gerrit.wikimedia.org/r/686663

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1:Visit https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=2 or https://wikidata.beta.wmflabs.org
/wiki/Main_Page and confirm the languages option displays outside the dropdown menu.

✅ AC3: visit Monobook and confirm languages option is in top right at far left of links

Jdlrobson added a subscriber: Edtadros.

This can skip QA in production. It can't be tested there until the feature is deployed. We will do that prior to releasing the feature.

ovasileva claimed this task.

Resolving. Will have a separate task for QA for the full feature in production.