Page MenuHomePhabricator

There are too many files in the root of phase3/includes
Closed, ResolvedPublic

Description

A lot with similar purpose etc, 3 external Store...

Be nice to clear it up a bit


Version: unspecified
Severity: enhancement

Details

Reference
bz26220

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:14 PM
bzimport set Reference to bz26220.
bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Dec 3 2010, 8:18 PM
Reedy added a comment.Dec 3 2010, 8:56 PM

For MZMcBrides benefit, initial summary:

"There are too many files in the root of phase3/includes"

A snapshot of the directory contents right now:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/?pathrev=77679

A "conf" subdirectory could hold DefaultSettings.php, tidy.conf, SiteConfiguration.php and likely some other files.

A "profile" subdirectory seems like it could hold some files as well.

That said, no decent justification has been given (yet) for moving anything around, other than it would "be nice."

Reedy added a comment.Dec 3 2010, 9:07 PM

Profile as in Profiler?

That's a no go. It seems there are some weird explicit dependencies from maintenance and others. I tried to move that before and all hell broke loose

(In reply to comment #3)

Profile as in Profiler?

That's a no go. It seems there are some weird explicit dependencies from
maintenance and others. I tried to move that before and all hell broke loose

Yes, I was referring to Profiler.php, ProfilerSimple.php, ProfilerSimpleText.php, ProfilerSimpleTrace.php, ProfilerSimpleUDP.php, and ProfilerStub.php.

demon added a comment.Dec 5 2010, 4:32 AM

(In reply to comment #3)

Profile as in Profiler?

That's a no go. It seems there are some weird explicit dependencies from
maintenance and others. I tried to move that before and all hell broke loose

Because our batshit profiler instructions require you to require Profiler.php, which is stupid. We'd have to leave an alias in place for back-compat, which would render the move pointless.

Some of the profiler helper stuff may be movable.

Reedy added a comment.Dec 5 2010, 9:34 AM

(In reply to comment #5)

Because our batshit profiler instructions require you to require Profiler.php,
which is stupid. We'd have to leave an alias in place for back-compat, which
would render the move pointless.

Some of the profiler helper stuff may be movable.

Couldn't we just do this, and "deprecate" it under the normal ways... ie just leave for 1.17, 1.18 mark wfDeprecated...

Not brilliant, but a step in the right direction

Also, the instructions suck - "Modify the StartProfiler.php". Which StartProfiler.php?

A quick look at the code says it needs to be in the root. But who knew? I guess http://www.mediawiki.org/w/index.php?title=StartProfiler.php&action=edit&redlink=1 should be created

Reedy added a comment.Dec 5 2010, 9:45 AM

We'd also possibly need to leave ProfilerStub.php/an includes/alias file

Just incase anyone has a base StartProfiler.php that includes ProfilerStub.php for some daft reason

Seeing as that duplicates methods from Profiler....

With the alias files, 6 can be moved, leaving 2 "deprecated" redirects...

Reedy added a comment.Dec 5 2010, 9:55 AM

Created attachment 7887
Patch to do all of the moving...

attachment moveprofiler.diff ignored as obsolete

Reedy added a comment.Dec 5 2010, 9:57 AM

Created attachment 7888
Really move profiler

attachment moveprofiler.diff ignored as obsolete

Reedy added a comment.Dec 5 2010, 2:36 PM

Comment on attachment 7888
Really move profiler

Not worth the effort (at all) with Profiler stuff.

demon added a comment.Apr 18 2011, 2:09 AM

I reorganized the profiler in r86175 and followups.

Is there anything else to get moved or can we just close this bug? I am not sure there is any point in keeping it around.

demon added a comment.Nov 8 2011, 8:13 PM

(In reply to comment #12)

Is there anything else to get moved or can we just close this bug? I am not
sure there is any point in keeping it around.

I think we can go ahead and close this.