Page MenuHomePhabricator

MediaWiki:Rev-deleted-text-permission displays instead of MediaWiki:Rev-suppressed-text-permission when a non-oversighter tries to view a suppressed diff
Open, Needs TriagePublic

Description

Hi Dev Team,

Reproduction steps:

  1. Log out of Wikipedia (don't use an account) or use an account that does not have oversight permissions.
  2. Visit a diff that's suppressed that's formatted in this manner: https://en.wikipedia.org/w/index.php?title=[PAGE NAME]&oldid=[OLD ID]

I ran into this while I was looking into a matter that was posted to the English Wikipedia oversight email list. When I went to view a suppressed diff while I was logged out (in a Firefox incognito window), I noticed something that wasn't right...

When logged out and visiting a suppressed diff, you will be presented with the following error text (from MediaWiki:rev-deleted-text-permission): "This page revision has been removed from the public archives. Details can be found in the deletion log for this page."

This is not correct. It should instead be presenting the error text from MediaWiki:rev-suppressed-text-permission: "This page revision has been suppressed. Details can be found in the suppression log."

On another note: This may not be the place to ask, but is MediaWiki:rev-suppressed-text-permission only displayed when a user visits a suppressed diff that is not an oversighter and hence cannot see the revision? Is there another situation where this might be displayed? If so, it's pointless to have "Details can be found in the suppression log" added to the error notice, since non-oversighters don't have access to the suppression log.

Creating a ticket to have this looked into.

Event Timeline

Oshwah renamed this task from MediaWiki:Rev-deleted-text-permission displays instead of MediaWiki:Rev-suppressed-text-permission when a logged out user tries to view a suppressed diff to MediaWiki:Rev-deleted-text-permission displays instead of MediaWiki:Rev-suppressed-text-permission when a non-oversighter tries to view a suppressed diff.May 7 2021, 1:14 AM
Oshwah updated the task description. (Show Details)
Umherirrender added a subscriber: Umherirrender.

rev-suppressed-text-permission is only used on Special:Undelete. All other places does not make a different between normal and restricted, if the user is not able to see the content.

Usage for rev-suppressed-text-permission: https://codesearch.wmcloud.org/search/?q=rev-suppressed-text-permission&i=nope&files=%5C.php&excludeFiles=&repos=
Usage for rev-deleted-text-permission: https://codesearch.wmcloud.org/search/?q=rev-deleted-text-permission&i=nope&files=%5C.php&excludeFiles=&repos=

Change 692416 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Provide proper message for no-perm suppressed edit view context

https://gerrit.wikimedia.org/r/692416