Page MenuHomePhabricator
Create Task
Maniphest T282207

PHP Deprecated: WikiPage constructed on a Title that cannot exist as a page: mw:User:TCipriani (WMF) [Called from CirrusSearch\Updater::updateLinkedArticles]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: WikiPage constructed on a Title that cannot exist as a page: mw:User:TCipriani (WMF) [Called from CirrusSearch\Updater::updateLinkedArticles]
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.4/extensions/CirrusSearch/includes/Updater.php(374)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.37.0-wmf.4/includes/debug/MWDebug.php(376): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.4/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.37.0-wmf.4/includes/GlobalFunctions.php(1068): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.4/includes/page/WikiPage.php(182): wfDeprecatedMsg(string, string)
#5 /srv/mediawiki/php-1.37.0-wmf.4/extensions/CirrusSearch/includes/Updater.php(374): WikiPage->__construct(Title)
#6 /srv/mediawiki/php-1.37.0-wmf.4/extensions/CirrusSearch/includes/Job/IncomingLinkCount.php(39): CirrusSearch\Updater->updateLinkedArticles(array)
#7 /srv/mediawiki/php-1.37.0-wmf.4/extensions/CirrusSearch/includes/Job/JobTraits.php(136): CirrusSearch\Job\IncomingLinkCount->doJob()
#8 /srv/mediawiki/php-1.37.0-wmf.4/includes/jobqueue/JobRunner.php(373): CirrusSearch\Job\CirrusTitleJob->run()
#9 /srv/mediawiki/php-1.37.0-wmf.4/includes/jobqueue/JobRunner.php(334): JobRunner->doExecuteJob(CirrusSearch\Job\IncomingLinkCount)
#10 /srv/mediawiki/php-1.37.0-wmf.4/includes/jobqueue/JobRunner.php(247): JobRunner->executeJob(CirrusSearch\Job\IncomingLinkCount)
#11 /srv/mediawiki/php-1.37.0-wmf.4/maintenance/runJobs.php(93): JobRunner->run(array)
#12 /srv/mediawiki/php-1.37.0-wmf.4/maintenance/doMaintenance.php(108): RunJobs->execute()
#13 /srv/mediawiki/php-1.37.0-wmf.4/maintenance/runJobs.php(130): require_once(string)
#14 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
#15 {main}
Impact

Presumed no direct impact as deprecations (should) mean that the discouraged logic still works as well as it did before. However, as being a deprecation in prod, it means by definition it was thought to be unused and turns out not to be, hence high priority and blocking the (next) train.

Notes

See also:

\cc @daniel

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check if target exists before calling WikiPagemediawiki/extensions/CirrusSearchREL1_36+2 -2
Check if target exists before calling WikiPagemediawiki/extensions/CirrusSearchmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.May 7 2021, 3:55 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 7 2021, 3:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle added a parent task: T281146: 1.37.0-wmf.5 deployment blockers.May 7 2021, 3:55 AM
gerritbot added a comment.May 7 2021, 8:25 AM

Change 686387 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CirrusSearch@master] Check if target exists before calling WikiPage

https://gerrit.wikimedia.org/r/686387

gerritbot added a project: Patch-For-Review.May 7 2021, 8:25 AM
Zabe subscribed.May 7 2021, 8:50 AM
gerritbot added a comment.May 7 2021, 4:13 PM

Change 686387 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Check if target exists before calling WikiPage

https://gerrit.wikimedia.org/r/686387

Zabe claimed this task.May 7 2021, 4:13 PM
Zabe triaged this task as High priority.

Should be fixed, could someone check?

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 7 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 7 2021, 5:10 PM
Zabe added a project: User-Zabe.May 7 2021, 9:17 PM
• MPhamWMF moved this task from needs triage to watching / waiting on the Discovery-Search board.May 10 2021, 3:10 PM
Jdforrester-WMF closed this task as Resolved.May 10 2021, 11:10 PM
Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.Jun 12 2021, 5:44 PM
Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM
gerritbot added a comment.Sep 29 2021, 1:39 PM

Change 724744 had a related patch set uploaded (by Abijeet Patro; author: Zabe):

[mediawiki/extensions/CirrusSearch@REL1_36] Check if target exists before calling WikiPage

https://gerrit.wikimedia.org/r/724744

gerritbot added a project: Patch-For-Review.Sep 29 2021, 1:39 PM
gerritbot added a comment.Oct 8 2021, 11:57 PM

Change 724744 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_36] Check if target exists before calling WikiPage

https://gerrit.wikimedia.org/r/724744

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2021, 12:10 AM
Zabe removed a project: User-Zabe.Apr 13 2022, 12:50 AM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.Feb 12 2025, 9:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits