Maniphest T282226

Add unit tests for SchulzeTallier class
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	May 7 2021, 9:30 AM

Tags

Referenced Files

None

Subscribers

Description

Add SchulzeTallier class, which should extend MediaWikiUnitTestCase.

It should aim to test most public methods, though some judgement may be required as to which are worth testing.

Details

	Subject	Repo	Branch	Lines +/-
	Add unit tests for SchulzeTallier class	mediawiki/extensions/SecurePoll	master	+135 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T282008 Add unit tests for major SecurePoll components
		Open		None	T282218 Add unit tests for the Tallier classes
		Resolved		STran	T282226 Add unit tests for SchulzeTallier class

Event Timeline

Tchanders created this task.May 7 2021, 9:30 AM

Tchanders moved this task from Untriaged to The Letter Song on the Anti-Harassment board.

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran claimed this task.May 7 2021, 11:59 AM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 689154 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/SecurePoll@master] [WIP] Add unit tests for SchulzeTallier class

https://gerrit.wikimedia.org/r/689154

gerritbot added a project: Patch-For-Review.May 11 2021, 4:33 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.May 12 2021, 5:58 PM

Tchanders moved this task from Code Review 🔍 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.May 13 2021, 12:01 PM

Change 689154 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Add unit tests for SchulzeTallier class

https://gerrit.wikimedia.org/r/689154

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 13 2021, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 1:10 PM

• Niharika closed this task as Resolved.May 22 2021, 1:47 PM