Page MenuHomePhabricator

Wikitext unparsed in TemplateSandbox text box label of the 2017 wikitext editor
Closed, ResolvedPublic

Description

Related to T153367 which was recently merged into 1.37.

The text box added in by TemplateSandbox on the 2017 wikitext editor has a label made with wikitext. The problem is that it's left unparsed. See the attached screenshot for a view of it on the English Wikipedia.

Event Timeline

The link is supportable in JavaScript, but the template is not: see https://www.mediawiki.org/wiki/Manual:Messages_API#Feature_support_in_JavaScript. I would suggest removing it since varying on "template" vs "module" is kind of overkill for this.

Change 691520 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/TemplateSandbox@master] Parse templatesandbox-editform-legend message in VisualEditor

https://gerrit.wikimedia.org/r/691520

With my patch and the template removed from the message, it looks like:

Change 691520 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Parse templatesandbox-editform-legend message in VisualEditor

https://gerrit.wikimedia.org/r/691520

Legoktm claimed this task.

Will be deployed as part of this week's train. I also updated the en.wp message to remove the template: https://en.wikipedia.org/w/index.php?title=MediaWiki%3ATemplatesandbox-editform-legend&type=revision&diff=1023694665&oldid=684180049