Page MenuHomePhabricator

[email] Theming issue causes text to be unreadable
Closed, ResolvedPublic

Description

From an email:
"Thank you for resolving my previous concern but I do encounter a different problem with the Wikipedia app.

This time, certain wikitable has their text missing or blending in the background unless I highlight them to make them appear.

Below is a sample Wikipedia page titled "Oneechan ga Kita" that contains a wikitable under the "Anime" page section. The first image shows the information missing on the table however on the second image, the text reappears if I highlight them.

This issue only happens when the app's theme is set to "dark"."

Steps to Reproduce

  1. Access https://en.wikipedia.org/api/rest_v1/page/mobile-html/Oneechan_ga_Kita?theme=dark
  2. Go to "Anime" section
  3. Observe infobox

Expected Results

  • Text inside table is readable in dark/black theme

Actual Results

  • Text color is white and is not readable

Environments Observed

  • (enwiki) Production

Additional notes

  • The table is not applying background color, for some reason text is not being affected by notheme logic

Event Timeline

MSantos subscribed.

It seems that some collapsible tables are receiving notheme class, but their content isn't. This means that the theme CSS will prevail.

@MattCleinman and @Dbrant could you please decide on the priority?

LGoto triaged this task as Medium priority.Jun 4 2021, 4:42 PM

Report from an Android user:

Lists cannot be read in dark mode

I was able to reproduce it on the article: Omega (Epica Album)

image.png (2×1 px, 294 KB)

Change 699784 had a related patch set uploaded (by MSantos; author: MSantos):

[mediawiki/services/mobileapps@master] mobile-html: fix styling issues for td elements

https://gerrit.wikimedia.org/r/699784

Change 699784 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] mobile-html: fix styling issues for td elements

https://gerrit.wikimedia.org/r/699784

This comment was removed by MSantos.
MSantos claimed this task.

Acknowledging that there are other black/dark theme issues, but those have their own tasks. The issue in this ticket is resolved.