Page MenuHomePhabricator
Create Task
Maniphest T282304

Regression: Language links are visible on the print version
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Kwj2772
May 8 2021, 6:09 AM
Tags
Referenced Files
F34525643: image.png
Jun 24 2021, 3:31 PM
F34524395: Screen Shot 2021-06-23 at 5.46.52 PM.png
Jun 24 2021, 12:49 AM
F34524397: Screen Shot 2021-06-23 at 5.47.43 PM.png
Jun 24 2021, 12:49 AM
F34524396: Screen Shot 2021-06-23 at 5.48.11 PM.png
Jun 24 2021, 12:49 AM
F34524394: Screen Shot 2021-06-23 at 5.45.48 PM.png
Jun 24 2021, 12:49 AM
F34519900: Screen Shot 2021-06-21 at 9.36.03 PM.png
Jun 22 2021, 4:38 AM
F34519898: Screen Shot 2021-06-21 at 9.36.20 PM.png
Jun 22 2021, 4:38 AM
F34446023: enwiki main page print-version interlanguage link.png
May 8 2021, 8:15 AM
Subscribers
Aklapper
cjming
Edtadros
Jdlrobson
Kwj2772
Thibaut120094

Description

On the wikis where interlanguage links have been moved to top right as a "p-lang-btn-label", language links and label are visible in printable versions. They are printed on the first page.

enwiki main page print-version interlanguage link.png (573×799 px, 34 KB)

Those links should be hidden.

QA steps

QA Results - Beta

ACStatusDetails
1✅T282304#7168474

QA Results - Prod

ACStatusDetails
1✅T282304#7174077

Details

SubjectRepoBranchLines +/-
Hide language links on print versionmediawiki/skins/Vectormaster+1 -0
Hide language links on print versionmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

Kwj2772 created this task.May 8 2021, 6:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2021, 6:09 AM
Kwj2772 triaged this task as High priority.May 8 2021, 6:44 AM
Kwj2772 updated the task description. (Show Details)
Kwj2772 updated the task description. (Show Details)May 8 2021, 8:15 AM
Aklapper raised the priority of this task from High to Needs Triage.May 8 2021, 8:37 AM
Jdlrobson added projects: Vector (legacy skin), Web-Team-Backlog.May 26 2021, 3:28 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
ovasileva renamed this task from Language links are visible on the print version to Regression: Language links are visible on the print version.Jun 7 2021, 3:57 PM
ovasileva triaged this task as Medium priority.
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 7 2021, 5:03 PM
Jdlrobson subscribed.

Language links are hidden via #mw-navigation in the old skin. Presumably, we need to add a new selector to that query that targets the language selector now that's it outside that element.

LGoto set the point value for this task to 1.Jun 7 2021, 5:35 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming claimed this task.Jun 9 2021, 10:43 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 9 2021, 10:55 PM

Change 699081 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] Hide language links on print version

https://gerrit.wikimedia.org/r/699081

gerritbot added a project: Patch-For-Review.Jun 9 2021, 10:55 PM
cjming removed cjming as the assignee of this task.Jun 9 2021, 11:23 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming subscribed.
cjming claimed this task.Jun 10 2021, 12:28 AM
cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 10 2021, 12:30 AM

Change 699081 abandoned by Clare Ming:

[mediawiki/core@master] Hide language links on print version

Reason:

moving to Vector repo

https://gerrit.wikimedia.org/r/699081

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2021, 1:10 AM
gerritbot added a comment.Jun 10 2021, 9:25 PM

Change 699284 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Hide language links on print version

https://gerrit.wikimedia.org/r/699284

gerritbot added a project: Patch-For-Review.Jun 10 2021, 9:25 PM
cjming removed cjming as the assignee of this task.Jun 10 2021, 9:32 PM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson assigned this task to Edtadros.Jun 10 2021, 11:13 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 10 2021, 11:30 PM

Change 699284 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide language links on print version

https://gerrit.wikimedia.org/r/699284

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 11 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 12:11 AM
cjming updated the task description. (Show Details)Jun 11 2021, 10:31 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 22 2021, 4:38 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit an article in the beta cluster (i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein)
✅ AC1: Bring up a print dialog box and note that the 1st page is the content of the page, not an endless list of languages.

Screen Shot 2021-06-21 at 9.36.20 PM.png (833×1 px, 305 KB)

Screen Shot 2021-06-21 at 9.36.03 PM.png (691×953 px, 247 KB)

Edtadros updated the task description. (Show Details)Jun 22 2021, 4:38 AM
Edtadros reassigned this task from Edtadros to ovasileva.Jun 24 2021, 12:49 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: chowiki, testwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit an article
✅ AC1: Bring up a print dialog box and note that the 1st page is the content of the page, not an endless list of languages.

Screen Shot 2021-06-23 at 5.45.48 PM.png (1×1 px, 323 KB)

Screen Shot 2021-06-23 at 5.46.52 PM.png (1×1 px, 362 KB)

Screen Shot 2021-06-23 at 5.48.11 PM.png (1×1 px, 567 KB)

Screen Shot 2021-06-23 at 5.47.43 PM.png (1×1 px, 518 KB)

Edtadros updated the task description. (Show Details)Jun 24 2021, 12:50 AM
ovasileva closed this task as Resolved.Jun 24 2021, 1:37 PM
Thibaut120094 reopened this task as Open.EditedJun 24 2021, 3:25 PM
Thibaut120094 subscribed.

Sorry to reopen this but the problem is now present on frwiki: The bug can be reproduced here: https://fr.wikipedia.org/wiki/Theria?languageinheader=1

Screenshot on Firefox 89.0.2:

image.png (1×2 px, 421 KB)

Same problem with the "Download as PDF" tool.

Jdlrobson closed this task as Resolved.Jun 24 2021, 3:32 PM

@Thibaut120094 French Wikipedia is still running 1.37.0-wmf.9 (last week's deploy), the fix is in the 1.37.0-wmf.11 release (this weeks deploy) which is live on https://test.wikipedia.org/wiki/Special:Version and mediawiki.org, so this will be fixed in the next release.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL