Page MenuHomePhabricator
Create Task
Maniphest T282387

Can't type slash character ("/") in Gerrit web editor [fixed in Gerrit 3.3.6]
Closed, ResolvedPublic
Actions

Description

When doing https://gerrit.wikimedia.org/r/c/operations/puppet/+/687410/1, pretty sure my title was also longer. I tried to type a / when editing lists.pp and nothing happened.

I'm on iOS 14.5.1 iPhone 8 (MQ6H2B/A) -
Google Chrome 87.0.4280.163 (Official Build) stable (64-bit)
Revision 2db81d50f66a...

Related Objects
Search...

Event Timeline

RhinosF1 created this task.May 9 2021, 5:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2021, 5:37 PM
Reedy added a project: Mobile.May 10 2021, 1:17 AM
Aklapper renamed this task from Cant type / in gerrit web editor to Can't type slash character ("/") in Gerrit web editor.May 10 2021, 7:17 AM
ovasileva moved this task from Needs triage to Triaged on the Mobile board.May 10 2021, 2:36 PM
Paladox moved this task from Bugs & stuff to PolyGerrit on the Gerrit board.Jun 29 2021, 10:05 PM
Paladox subscribed.

This seems fixed at least on gerrit master... I'm not sure what change fixed it tho.

Paladox added a comment.Jun 29 2021, 11:15 PM

Ok, I know how it was fixed upstream though I'm not sure if that change can be back ported.

Paladox added a comment.Jun 30 2021, 12:07 AM

Backported the change here: https://gerrit-review.googlesource.com/c/gerrit/+/310683

Paladox added a project: Upstream.Jun 30 2021, 12:09 AM
Paladox moved this task from Backlog to Patch proposed upstream on the Upstream board.
hashar assigned this task to Paladox.Jun 30 2021, 2:55 PM
Paladox added a comment.Jul 2 2021, 1:39 PM

Upstream rejected back porting that change. We will have to wait for gerrit 3.5 for the fix.

Aklapper renamed this task from Can't type slash character ("/") in Gerrit web editor to Can't type slash character ("/") in Gerrit web editor [fixed in Gerrit 3.5].Jul 9 2021, 12:13 PM
Aklapper moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.
Paladox added a comment.Aug 10 2021, 7:58 AM

Upstream fix merged and I've backported it to https://gerrit-review.googlesource.com/c/plugins/codemirror-editor/+/314364 which has been merged.

RhinosF1 renamed this task from Can't type slash character ("/") in Gerrit web editor [fixed in Gerrit 3.5] to Can't type slash character ("/") in Gerrit web editor [fixed in Gerrit 3.3.6].Sep 2 2021, 2:56 PM
hashar added a subtask: T290236: Upgrade Gerrit from 3.3.5 to 3.3.6.Oct 11 2021, 9:45 AM
hashar subscribed.Oct 11 2021, 9:51 AM

We have upgraded to Gerrit 3.3.6 which has Paladox patch. So tentatively this issue has been fixed.

hashar closed this task as Resolved.Oct 11 2021, 10:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL