Clarify unclosed tags message
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Samwalton9-WMF
	May 10 2021, 11:10 AM

Description

I just went to send a MassMessage (containing a bunch of HTML tags) and was presented with the following message in a red box:

Your message may have unclosed HTML tags: <div>, <span>, <big>, <small>.

I assumed this meant that there actually were unclosed tags so I spent a bunch of time checking and re-checking. I've checked the message in an online tag checker tool and it confirmed there are in fact no unclosed tags.

This tag should clarify that it's only asking you to double check all HTML tags are closed, rather than being a warning that something needs to change, like the other red boxes in this dialog (e.g. no subject)

Event Timeline

Samwalton9-WMF created this task.May 10 2021, 11:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2021, 11:10 AM

I think the message could benefit both from rewording and from not being a red message box. There are other red boxes used in this tool to let you know that you're, for example, missing a subject or delivery list. Getting this red message makes it seem like it's also a blocker to sending the message. The text could be reworded to something like "Please check you don't have any unclosed HTML tags" instead of the vague "may have" language.

Nikerabbit moved this task from Backlog to Delivery form on the MassMessage board.Jan 26 2022, 10:02 AM

The form now only shows this message when the tags are actually unclosed and also only uses a yellow background (instead of red). As such, the concerns raised here are addressed and this can be resolved.

Clarify unclosed tags messageClosed, ResolvedPublicActions

Description

Event Timeline

Clarify unclosed tags message
Closed, ResolvedPublic
Actions