Page MenuHomePhabricator

Use $wgEnablePartialActionBlocks feature flag for block list and block log [L]
Closed, ResolvedPublic

Description

We should update Special:BlockList and the block log to ensure that action blocks do not display if $wgEnablePartialActionBlocks is false.

Usually it is not possible to make an partial block against actions, unless the feature is enabled. However, it is possible that the feature could be enabled then disabled again.

In this case, we shouldn't display information about blocked actions in the block list or log, because it is misleading, since the block target won't actually be blocked from performing the action any more.

Some tests may also need updating to set the flag to true temporarily for the test.

Event Timeline

ARamirez_WMF renamed this task from Use $wgEnablePartialActionBlocks feature flag for block list and block log to Use $wgEnablePartialActionBlocks feature flag for block list and block log [L].May 12 2021, 4:15 PM

Change 696795 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/core@master] Use $wgEnablePartialActionBlocks feature flag for block list and block log

https://gerrit.wikimedia.org/r/696795

Change 696795 merged by jenkins-bot:

[mediawiki/core@master] Use $wgEnablePartialActionBlocks feature flag for block list and block log

https://gerrit.wikimedia.org/r/696795

dom_walden added a subscriber: dom_walden.

Special:BlockList with $wgEnablePartialActionBlocks = true:

action_blocklist_before.png (520×1 px, 58 KB)

Special:BlockList with $wgEnablePartialActionBlocks = false:

action_blocklist_after.png (251×1 px, 38 KB)

Special:Log/block with $wgEnablePartialActionBlocks = true:

action_blocklog_before.png (197×1 px, 93 KB)

Special:Log/block with $wgEnablePartialActionBlocks = false:

action_blocklog_after.png (150×1 px, 79 KB)

It can lead to interesting log lines like: blocked <user> from with an expiration time..., which we might want to deal with in a different ticket.

Test Environment: local docker MediaWiki 1.37.0-alpha (4494ac4) 05:21, 3 June 2021.