Use $wgEnablePartialActionBlocks feature flag for block list and block log [L]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	May 10 2021, 2:20 PM

Description

We should update Special:BlockList and the block log to ensure that action blocks do not display if $wgEnablePartialActionBlocks is false.

Usually it is not possible to make an partial block against actions, unless the feature is enabled. However, it is possible that the feature could be enabled then disabled again.

In this case, we shouldn't display information about blocked actions in the block list or log, because it is misleading, since the block target won't actually be blocked from performing the action any more.

Some tests may also need updating to set the flag to true temporarily for the test.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use $wgEnablePartialActionBlocks feature flag for block list and block log	mediawiki/core	master	+7 -3

Customize query in gerrit

Related Objects

Mentioned In: T282655: Hide action restrictions behind feature flag in ApiQueryBlocks
Mentioned Here: rMW4494ac49c0ae: Merge "Remove some User typehints that are just passthrough"

Event Timeline

Tchanders created this task.May 10 2021, 2:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2021, 2:20 PM

Tchanders updated the task description. (Show Details)May 10 2021, 6:19 PM

dom_walden mentioned this in T282655: Hide action restrictions behind feature flag in ApiQueryBlocks.May 12 2021, 8:25 AM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.May 12 2021, 1:11 PM

ARamirez_WMF renamed this task from Use $wgEnablePartialActionBlocks feature flag for block list and block log to Use $wgEnablePartialActionBlocks feature flag for block list and block log [L].May 12 2021, 4:15 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.May 13 2021, 1:59 PM

Niharika edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.

• TThoabala claimed this task.May 25 2021, 4:24 AM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.May 25 2021, 3:53 PM

Change 696795 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/core@master] Use $wgEnablePartialActionBlocks feature flag for block list and block log

https://gerrit.wikimedia.org/r/696795

gerritbot added a project: Patch-For-Review.May 28 2021, 3:19 AM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jun 2 2021, 5:19 AM

STran moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Jun 2 2021, 1:49 PM

Change 696795 merged by jenkins-bot:

[mediawiki/core@master] Use $wgEnablePartialActionBlocks feature flag for block list and block log

https://gerrit.wikimedia.org/r/696795

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 2 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2021, 3:10 PM

Special:BlockList with $wgEnablePartialActionBlocks = true:

action_blocklist_before.png (520×1 px, 58 KB)

Special:BlockList with $wgEnablePartialActionBlocks = false:

Special:Log/block with $wgEnablePartialActionBlocks = true:

Special:Log/block with $wgEnablePartialActionBlocks = false:

It can lead to interesting log lines like: blocked <user> from with an expiration time..., which we might want to deal with in a different ticket.

Test Environment: local docker MediaWiki 1.37.0-alpha (4494ac4) 05:21, 3 June 2021.

Niharika closed this task as Resolved.Jun 14 2021, 1:49 PM

Use $wgEnablePartialActionBlocks feature flag for block list and block log [L]Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Use $wgEnablePartialActionBlocks feature flag for block list and block log [L]
Closed, ResolvedPublic
Actions