Page MenuHomePhabricator

Rename tests with identical names
Open, MediumPublic

Description

Task
We currently have a number of tests with the same name as another test. These should be renamed to ensure all our tests run correctly.

The 5 tests are listed at https://deepsource.io/gh/Samwalton9/TWLight/issue/PYL-E0102/occurrences (note this reflects a fork of the TWLight repository - commits should be made at WikipediaLibrary/TWLight).

To complete this task, rename each test noted there to have a different name which is unique.

Good first task

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

The Library Card platform repository can be found at WikipediaLibrary/TWLight. Please see the Getting Started and Local Setup guides to get up and running with a local development environment.

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9 renamed this task from Fix tests with identical names to Rename tests with identical names.May 10 2021, 2:46 PM
Samwalton9 triaged this task as Medium priority.

After following the steps for installation, I'm left at this error at localhost:

OperationalError at /
(1054, "Unknown column 'resources_partner.new_tags' in 'field list'")

This could be due to an error due to migration. This error came repeatedly while the migration script ran:

The field users.Authorization.partners was declared with a lazy reference to 'resources.partner', but app 'resources' isn't installed.
The field users.Authorization.stream was declared with a lazy reference to 'resources.stream', but app 'resources' isn't installed.
The field users.Authorization_partners.partner was declared with a lazy reference to 'resources.partner', but app 'resources' isn't installed.
sync_translation_fields

I've also certified that my fork is up to date.

Please let me know how to resolve this issue.

This seems like it would be related to T282034. @Scardenasmolinar Any idea why this error might be happening?

@infinite_verma Can you go to the bash of the container and run the migrations manually?