Page MenuHomePhabricator

[GOAL] Use the Codex search widget inside the mobile site
Open, HighPublic

Description

Specific: What do we want to achieve

In February 2021, Jon (that's me!) explored using Vue.js and the new wvui search inside the mobile site. The change would throw away 782 lines of code while adding only 96 .

The exercise was helpful in:

Given our upcoming work on desktop improvements making search work at lower resolutions this is a good opportunity to tackle search from another angle.

Measurable: How will we know when we've reached our goal?

This goal can be closed when there are no open subtasks and the mobile site uses the WVUI component. Subtasks can be removed if deemed too complicated given the timeframe.

TEST FOR DONE:

  • A feature flag allows us to switch between Vue.js and the existing View code.
  • When feature flag enabled, Codex and the search widget are loaded in the search overlay.
  • The new Codex search is instrumented

Achievable: What support will we need to achieve our goal?

Might be blocked on the new API for wikidata (unless we are willing to disable search on wikidata.org, see subtasks).

Would require Alex design input as there are some subtle changes

Relevant: Is this goal worthwhile?

Yes. Having one search widget to maintain across the mobile and desktop skin will be much easier for the team to manage, particularly given this would be as part of a shared component library shared with other teams.

This would also be helpful for the analytics team as it would add instrumentation for mobile search results. Currently mobile search autocomplete traffic is not instrumented.

Time-bound: What is the time frame? Can we achieve this goal in the timeframe we've set?

NOTE: TODO: Should be completed by 1.37 release or the end of quarter 1 ( 09/30/2021 ), whichever is sooner.

QA

  • The overlay only shows when the person starts typing
  • When tapping into search in Minerva there should never be the illusion the page has disappeared (see T216743 for more context on what we'd like to avoid)
  • Control+clicking should work (T206347)
  • Watchstar will no longer display in search results (T267534)

Related Objects

StatusSubtypeAssignedTask
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
OpenNone
OpenNone
StalledBUG REPORTNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedAnneT
Openovasileva
ResolvedVolker_E
OpenNone
OpenNone
Openovasileva
OpenNone
OpenNone
Openovasileva
StalledNone
OpenNone
OpenNone
ResolvedStevenSun
DeclinedJdrewniak
Resolvedovasileva
OpenBUG REPORTNone
ResolvedCatrope
Resolvedovasileva
OpenBUG REPORTNone
OpenBUG REPORTNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson renamed this task from Use the wvui search widget inside the mobile site to [GOAL] Use the wvui search widget inside the mobile site.May 10 2021, 5:34 PM
Jdlrobson renamed this task from [GOAL] Use the wvui search widget inside the mobile site to [GOAL] Use the WVUI search widget inside the mobile site.Jun 22 2021, 9:01 PM
Jdlrobson renamed this task from [GOAL] Use the WVUI search widget inside the mobile site to [GOAL] Use the Codex search widget inside the mobile site.Mar 22 2022, 3:40 PM