Page MenuHomePhabricator

[GOAL] Use the Codex search widget inside the mobile and desktop site
Closed, ResolvedPublic1 Estimated Story Points

Description

See also: T321351

Specific: What do we want to achieve

In February 2021, Jon (that's me!) explored using Vue.js and the new wvui search inside the mobile site. The change would throw away 782 lines of code while adding only 96 .

The exercise was helpful in:

Given our upcoming work on desktop improvements making search work at lower resolutions this is a good opportunity to tackle search from another angle.

Jump forward to 2024 and we are now in a good place to do this.

Measurable: How will we know when we've reached our goal?

This goal can be closed when there are no open subtasks and the mobile site uses the same component as desktop. Subtasks can be removed if deemed too complicated given the timeframe.

TEST FOR DONE:

  • A feature flag allows us to switch between the Vue.js and the existing MobileFrontend code.
  • When feature flag enabled, Codex and the search widget are loaded in the search overlay.

Achievable: What support will we need to achieve our goal?

Might be blocked on the new API for wikidata (unless we are willing to disable search on wikidata.org, see subtasks).

Would require Alex and DST design input as there are some subtle changes

Relevant: Is this goal worthwhile?

Yes. Having one search widget to maintain across the mobile and desktop skin will be much easier for the team to manage, particularly given this would be as part of a shared component library shared with other teams.

This would also be helpful for the analytics team as it would add instrumentation for mobile search results. Currently mobile search autocomplete traffic is not instrumented.

Time-bound: What is the time frame? Can we achieve this goal in the timeframe we've set?
Q2.

QA

  • The overlay only shows when the person starts typing
  • When tapping into search in Minerva there should never be the illusion the page has disappeared (see T216743 for more context on what we'd like to avoid)
  • Control+clicking should work (T206347)
  • Watchstar will no longer display in search results (T267534)

Related Objects

StatusSubtypeAssignedTask
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
DeclinedNone
DeclinedNone
DeclinedBUG REPORTJdlrobson
ResolvedNone
ResolvedJdlrobson
ResolvedLucas_Werkmeister_WMDE
DuplicateNone
ResolvedLucas_Werkmeister_WMDE
ResolvedMichael
ResolvedMichael
DuplicateNone
Resolved AnneT
ResolvedNone
ResolvedNone
DeclinedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolved AnneT
ResolvedStevenSun
DeclinedJdrewniak
Resolvedovasileva
DuplicateBUG REPORTNone
ResolvedCatrope
Resolvedovasileva
ResolvedBUG REPORTEdtadros
ResolvedBUG REPORTovasileva

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson renamed this task from [GOAL] Use the WVUI search widget inside the mobile site to [GOAL] Use the Codex search widget inside the mobile site.Mar 22 2022, 3:40 PM
Jdlrobson set the point value for this task to 1.Sep 29 2022, 5:30 PM
Jdlrobson lowered the priority of this task from High to Low.Jun 16 2023, 10:56 PM
Jdlrobson raised the priority of this task from Low to Medium.Jul 17 2024, 6:22 PM
Jdlrobson renamed this task from [GOAL] Use the Codex search widget inside the mobile site to [GOAL] Use the Codex search widget inside the mobile and desktop site.Nov 21 2024, 4:55 PM
Jdlrobson updated the task description. (Show Details)