Page MenuHomePhabricator

[ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results
Closed, InvalidPublicSpike

Description

Description

With the current loading solution there is a use case that is not supported via a loading indicator:

  • WVUI loads quickly
  • the search results take longer than usual to return from the server

Behavior

Actual

  • Vector adds a loading state for loading WVUI after the search input is focused
  • Even after WVUI is loaded in, there could be a long period of time waiting for the initial search result to return. The typeahead-search component doesn't handle this at all.

Open questions

  • Should we add a loading state to the typeahead-search component for loading initial search results (only on the first search, and not on subsequent)
  • Are there any potential issues with having 2 loading states?

Event Timeline

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptMay 10 2021, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ovasileva triaged this task as Medium priority.May 11 2021, 5:03 PM
alexhollender_WMF renamed this task from [Spike] Consider adding a loading state to the typeahead-search component for loading search results to [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results.May 25 2021, 5:07 PM
alexhollender_WMF renamed this task from [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results to [Eng spike] Consider adding a loading state to the typeahead-search component for loading search results.
alexhollender_WMF renamed this task from [Eng spike] Consider adding a loading state to the typeahead-search component for loading search results to [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results.
alexhollender_WMF claimed this task.
alexhollender_WMF removed alexhollender_WMF as the assignee of this task.