Page MenuHomePhabricator

Fix failing browser tests on WikibaseLexeme's REL1_35 branch [timebox: 1 day]
Closed, ResolvedPublic8 Estimated Story Points

Description

For yet not identified reasons, WikibaseLexeme's two browser tests on REL1_35 branch have started to fail without the obvious reasons, effectively blocking - due to circular dependency in Wikibase's CI - blocking merging any changes to Wikibase's REL1_35 branch.

Faulty tests have been temporarily merged in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/685559 after failing to make those tests pass by making them wait more for certain elements to become visible/clickable.
Possible solution that has not been explored due to lack of time is update WDIO version used in REL1_35's tests - WikibaseLexeme tests seem to still use older WDIO version on this branch - Issues might potentially go away after the WDIO update.

Acceptance criteria🏕️🌟

  • FormId counter is not decremented when addForm is undone browser test is run on Jenkins CI and passes
  • FormId counter is not decremented when old revision is restored browser test is run on Jenkins CI and passes

Event Timeline

WMDE-leszek renamed this task from Fix failing browser tests on WikibaseLexeme's REL1_3 branch` to Fix failing browser tests on WikibaseLexeme's REL1_35 branch.May 10 2021, 7:09 PM
Addshore triaged this task as Medium priority.Wed, Jun 9, 10:05 AM
Lydia_Pintscher renamed this task from Fix failing browser tests on WikibaseLexeme's REL1_35 branch to Fix failing browser tests on WikibaseLexeme's REL1_35 branch [timebox: 1 day].Wed, Jun 9, 10:41 AM
Lydia_Pintscher set the point value for this task to 8.

Change 699774 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@REL1_35] Reenable browser tests on REL1_35

https://gerrit.wikimedia.org/r/699774

Change 699774 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@REL1_35] Reenable browser tests on REL1_35

https://gerrit.wikimedia.org/r/699774

Addshore added a subscriber: Addshore.

They look enabled and green