Add README for function-schemata
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	May 11 2021, 2:16 PM

Description

Documenting weirdness of package.json with javascript subdirectory

Details

	Subject	Repo	Branch	Lines +/-
	Add README/LICENSE/CODE_OF_CONDUCT files	mediawiki/services/function-schemata	master	+220 -0

Customize query in gerrit

Related Objects

Mentioned In: rMSFS5df06c0ae4e0: Add README/LICENSE/CODE_OF_CONDUCT files

Event Timeline

cmassaro created this task.May 11 2021, 2:16 PM

Change 689163 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-schemata@master] Add README/LICENSE/CODE_OF_CONDUCT files

https://gerrit.wikimedia.org/r/689163

gerritbot added a project: Patch-For-Review.May 11 2021, 4:41 PM

I've made a quick start. What "weirdness" specifically did you want to mention?

Jdforrester-WMF moved this task from To triage: Un-phased work to To Triage on the Abstract Wikipedia team board.May 11 2021, 4:44 PM

Ah, just that if you want to run tests locally, you need to symlink (or copy) package(-lock).json to the javascript/ subdirectory and run npm commands from there.

In T282567#7079096, @cmassaro wrote:

Ah, just that if you want to run tests locally, you need to symlink (or copy) package(-lock).json to the javascript/ subdirectory and run npm commands from there.

Fixed the first bit with https://gerrit.wikimedia.org/r/c/mediawiki/services/function-schemata/+/689167 but yeah, will add that too.

DVrandecic moved this task from To Triage to To triage: Un-phased work on the Abstract Wikipedia team board.May 12 2021, 4:26 PM

DVrandecic triaged this task as High priority.May 12 2021, 4:48 PM

Change 689163 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add README/LICENSE/CODE_OF_CONDUCT files

https://gerrit.wikimedia.org/r/689163

Jdforrester-WMF mentioned this in rMSFS5df06c0ae4e0: Add README/LICENSE/CODE_OF_CONDUCT files.May 12 2021, 9:11 PM

Maintenance_bot removed a project: Patch-For-Review.May 12 2021, 10:10 PM

Jdforrester-WMF closed this task as Resolved.May 13 2021, 12:11 AM

Jdforrester-WMF merged a task: T281946: Add missing standard documents to function-schemata.May 26 2021, 8:56 PM

Jdforrester-WMF added a subscriber: DVrandecic.