Page MenuHomePhabricator
Create Task
Maniphest T282665

Remove whitespace between PGN controls / buttons
Closed, ResolvedPublic
Actions

Description

Quickly clicking twice on a button seems to highlight the entire line of navigation buttons. This also highlights the whitespace between buttons which looks a bit surprising / confusing. Firefox 88.

Screenshot from 2021-05-12 12-12-34.png (244×554 px, 22 KB)

(Manually removed whitespace in HTML between first and second button, for comparison)

Details

SubjectRepoBranchLines +/-
Button accessibility improvementsmediawiki/extensions/ChessBrowsermaster+69 -49
Customize query in gerrit

Related Objects

Event Timeline

Aklapper triaged this task as Lowest priority.May 12 2021, 10:15 AM
Aklapper created this task.
Aklapper updated the task description. (Show Details)
TheDJ subscribed.Aug 30 2021, 10:27 AM

sounds like a missing event.preventDefault() or something. I'll check this later tonight.

gerritbot added a comment.Sep 2 2021, 9:55 PM

Change 716571 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/ChessBrowser@master] Button accessibility improvements

https://gerrit.wikimedia.org/r/716571

gerritbot added a project: Patch-For-Review.Sep 2 2021, 9:55 PM
TheDJ moved this task from Needs triage to In Progress on the ChessBrowser board.Sep 2 2021, 9:56 PM
gerritbot added a comment.Sep 3 2021, 6:02 AM

Change 716571 merged by jenkins-bot:

[mediawiki/extensions/ChessBrowser@master] Button accessibility improvements

https://gerrit.wikimedia.org/r/716571

Wugapodes mentioned this in rECHB36de75837897: Button accessibility improvements.Sep 3 2021, 6:02 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2021, 6:10 AM
TheDJ closed this task as Resolved.Sep 3 2021, 5:51 PM
TheDJ claimed this task.
TheDJ moved this task from In Progress to Completed on the ChessBrowser board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL