Page MenuHomePhabricator

Error when 'No label' items are displayed
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

We occasionally see attributes like - 'target' (image - F34451675) while retrieving items from the Curious Facts tool.

What happens?:

image.png (151×925 px, 75 KB)

image.png (151×922 px, 48 KB)

What should have happened instead?:

  • Attribute elements such as these should be avoided and not displayed to the user.
  • When there is an Item with no label defined (image2-F34451679), we must omit the No label defined and only display the ItemID - (Q29120387)

Event Timeline

@amy_rc Yes yes yes I know: deploying the bug fix is already on my To Do list!

Thank you for opening this ticket, I am on it.

Change 697690 had a related patch set uploaded (by GoranSMilovanovic; author: GoranSMilovanovic):

[analytics/wmde/WD/WikidataAnalytics@master] T282668

https://gerrit.wikimedia.org/r/697690

Change 697690 merged by GoranSMilovanovic:

[analytics/wmde/WD/WikidataAnalytics@master] T282668

https://gerrit.wikimedia.org/r/697690

Tested and now there are no such error displayed. 🎉