Page MenuHomePhabricator
Create Task
Maniphest T282689

Make `EntityDataSerializationService `& `RdfBuilder` services and inject them
Closed, ResolvedPublic
Actions

Description

Make EntityDataSerializationService & RdfBuilder services and inject them

Details

SubjectRepoBranchLines +/-
Renable tests with real RdfBuildermediawiki/extensions/WikibaseMediaInfomaster+1 -41
Renable tests with real RdfBuildermediawiki/extensions/WikibaseLexememaster+0 -8
Introduce and wire RdfBuilderFactory as servicemediawiki/extensions/Wikibasemaster+271 -272
Add typehints to previously touched filesmediawiki/extensions/Wikibasemaster+134 -249
Skip tests that use a real RdfBuilder while Refactoringmediawiki/extensions/WikibaseLexememaster+6 -0
Skip tests that use a real RdfBuilder while Refactoringmediawiki/extensions/WikibaseMediaInfomaster+7 -0
Fix WikibaseRepo.EntityDataSerializationService service wiringmediawiki/extensions/Wikibasemaster+46 -11
Wire EntityDataSerialisationService as a Servicemediawiki/extensions/Wikibasemaster+159 -51
Add Integration Test for EntityDataSerializationServicemediawiki/extensions/Wikibasemaster+65 -80
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.May 12 2021, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2021, 2:04 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 12 2021, 2:15 PM
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 19 2021, 12:05 PM
Tarrow claimed this task.Jun 17 2021, 10:46 AM
Tarrow moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jun 17 2021, 2:50 PM

Change 700196 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Wire EntityDataSerialisationService as a Service

https://gerrit.wikimedia.org/r/700196

gerritbot added a project: Patch-For-Review.Jun 17 2021, 2:50 PM

Change 700213 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Add Integration Test for EntityDataSerializationService

https://gerrit.wikimedia.org/r/700213

gerritbot added a comment.Jun 17 2021, 2:54 PM

Change 700213 abandoned by Tarrow:

[mediawiki/extensions/Wikibase@master] Add Integration Test for EntityDataSerializationService

Reason:

melded into 700196

https://gerrit.wikimedia.org/r/700213

gerritbot added a comment.Jun 24 2021, 11:28 AM

Change 700196 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Wire EntityDataSerialisationService as a Service

https://gerrit.wikimedia.org/r/700196

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 24 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 24 2021, 12:10 PM
gerritbot added a comment.Jun 25 2021, 3:35 PM

Change 701577 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix WikibaseRepo.EntityDataSerializationService service wiring

https://gerrit.wikimedia.org/r/701577

gerritbot added a project: Patch-For-Review.Jun 25 2021, 3:35 PM
gerritbot added a comment.Jun 28 2021, 10:10 AM

Change 700360 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Introduce and wire RdfBuilderFactory as service

https://gerrit.wikimedia.org/r/700360

gerritbot added a comment.Jun 28 2021, 10:31 AM

Change 701577 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix WikibaseRepo.EntityDataSerializationService service wiring

https://gerrit.wikimedia.org/r/701577

gerritbot added a comment.Jun 28 2021, 2:05 PM

Change 701921 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseLexeme@master] Skip tests that use a real RdfBuilder while Refactoring

https://gerrit.wikimedia.org/r/701921

gerritbot added a comment.Jun 28 2021, 2:05 PM

Change 701922 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseMediaInfo@master] Skip tests that use a real RdfBuilder while Refactoring

https://gerrit.wikimedia.org/r/701922

gerritbot added a comment.Jun 28 2021, 2:11 PM

Change 701924 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseMediaInfo@master] Renable tests with real RdfBuilder

https://gerrit.wikimedia.org/r/701924

gerritbot added a comment.Jun 28 2021, 2:11 PM

Change 701925 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseLexeme@master] Renable tests with real RdfBuilder

https://gerrit.wikimedia.org/r/701925

Addshore removed Tarrow as the assignee of this task.Jun 30 2021, 10:52 AM
Addshore moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore added a subscriber: Tarrow.
gerritbot added a comment.Jul 1 2021, 10:20 AM

Change 702605 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add typehints to previously touched files

https://gerrit.wikimedia.org/r/702605

Lucas_Werkmeister_WMDE claimed this task.Jul 1 2021, 10:24 AM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jul 1 2021, 10:49 AM

Change 701922 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Skip tests that use a real RdfBuilder while Refactoring

https://gerrit.wikimedia.org/r/701922

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 1 2021, 11:00 AM
gerritbot added a comment.Jul 1 2021, 1:48 PM

Change 701921 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Skip tests that use a real RdfBuilder while Refactoring

https://gerrit.wikimedia.org/r/701921

gerritbot added a comment.Jul 5 2021, 9:40 AM

Change 700360 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Introduce and wire RdfBuilderFactory as service

https://gerrit.wikimedia.org/r/700360

gerritbot added a comment.Jul 5 2021, 9:40 AM

Change 702605 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add typehints to previously touched files

https://gerrit.wikimedia.org/r/702605

gerritbot added a comment.Jul 5 2021, 10:01 AM

Change 701925 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Renable tests with real RdfBuilder

https://gerrit.wikimedia.org/r/701925

gerritbot added a comment.Jul 5 2021, 10:03 AM

Change 701924 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Renable tests with real RdfBuilder

https://gerrit.wikimedia.org/r/701924

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 5 2021, 10:44 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL