Page MenuHomePhabricator
Create Task
Maniphest T282697

Get rid of RepoEntityChange
Closed, ResolvedPublic
Actions

Description

The introduction of RepoEntityChange and RepoItemChange led to the problem outlined in the parent task. The code within RepoEntityChange does not need to live in a subclass of EntityChange so we can get rid of it as it may lead to confusion again in the future.

Planned steps:

Details

SubjectRepoBranchLines +/-
Move confusing metadata init codemediawiki/extensions/Wikibasemaster+36 -16
ChangeNotifier: extract change data handling into separate factorymediawiki/extensions/Wikibasemaster+470 -222
Remove RepoEntityChange and RepoItemChangemediawiki/extensions/Wikibasemaster+63 -143
Move remaining RepoEntityChange methods to ChangeNotifiermediawiki/extensions/Wikibasemaster+115 -172
Move RepoEntityChange::setMetadataFromRC to RecentChangeSaveHookHandlermediawiki/extensions/Wikibasemaster+26 -70
Extract RecentChangeSaveHookHandler from RepoHooksmediawiki/extensions/Wikibasemaster+219 -52
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.May 12 2021, 2:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2021, 2:53 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 12 2021, 3:15 PM
Maintenance_bot moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.
gerritbot added a comment.May 12 2021, 3:57 PM

Change 689946 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Extract RecentChangeSaveHookHandler from RepoHooks

https://gerrit.wikimedia.org/r/689946

gerritbot added a project: Patch-For-Review.May 12 2021, 3:57 PM
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 14 2021, 9:20 AM
gerritbot added a comment.May 14 2021, 11:00 AM

Change 691130 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Move RepoEntityChange::setMetadataFromRC to RecentChangeSaveHookHandler

https://gerrit.wikimedia.org/r/691130

gerritbot added a comment.May 14 2021, 1:14 PM

Change 691195 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Move remaining RepoEntityChange methods to ChangeNotifier

https://gerrit.wikimedia.org/r/691195

gerritbot added a comment.May 14 2021, 1:41 PM

Change 691202 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Remove RepoEntityChange and RepoItemChange

https://gerrit.wikimedia.org/r/691202

Jakob_WMDE updated the task description. (Show Details)May 14 2021, 1:49 PM
Jakob_WMDE updated the task description. (Show Details)
gerritbot added a comment.May 18 2021, 11:49 AM

Change 689946 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Extract RecentChangeSaveHookHandler from RepoHooks

https://gerrit.wikimedia.org/r/689946

gerritbot added a comment.May 18 2021, 11:55 AM

Change 691130 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move RepoEntityChange::setMetadataFromRC to RecentChangeSaveHookHandler

https://gerrit.wikimedia.org/r/691130

gerritbot added a comment.May 18 2021, 1:17 PM

Change 691195 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move remaining RepoEntityChange methods to ChangeNotifier

https://gerrit.wikimedia.org/r/691195

gerritbot added a comment.May 19 2021, 3:31 PM

Change 692903 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] ChangeNotifier: extract change data handling into separate factory

https://gerrit.wikimedia.org/r/692903

gerritbot added a comment.May 20 2021, 8:02 AM

Change 693127 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Remove superfluous metadata init

https://gerrit.wikimedia.org/r/693127

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 20 2021, 9:50 AM
Jakob_WMDE updated the task description. (Show Details)
gerritbot added a comment.May 20 2021, 10:50 AM

Change 691202 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove RepoEntityChange and RepoItemChange

https://gerrit.wikimedia.org/r/691202

gerritbot added a comment.May 20 2021, 3:32 PM

Change 692903 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ChangeNotifier: extract change data handling into separate factory

https://gerrit.wikimedia.org/r/692903

gerritbot added a comment.May 20 2021, 3:35 PM

Change 693127 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move confusing metadata init code

https://gerrit.wikimedia.org/r/693127

Maintenance_bot removed a project: Patch-For-Review.May 20 2021, 4:10 PM
Jakob_WMDE closed this task as Resolved.May 21 2021, 7:55 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL