Page MenuHomePhabricator

Create topic subscription table
Closed, ResolvedPublic

Description

In T263817, the Data-Persistence team reviewed and approved the table implementation the Editing-team proposed for storing topic subscriptions. This task about deploying said "table" to production.

Requirements

Done

  • All ===Requirements are met

Event Timeline

LSobanski added subscribers: LSobanski, Marostegui, Kormat.

Removing the team tag as the deployment is self-service. Adding a few subscribers for visibility.

Removing the team tag as the deployment is self-service. Adding a few subscribers for visibility.

@LSobanski: to confirm, by "self-service" do you mean the Editing-team should feel empowered to deploy the table to production ourselves?

EDIT: nevermind, @LSobanski! I'm now seeing you answered the above in the comment you made in T263817#7087636.

cc @Esanders

Removing the team tag as the deployment is self-service. Adding a few subscribers for visibility.

@LSobanski: to confirm, by "self-service" do you mean the Editing-team should feel empowered to deploy the table to production ourselves?

EDIT: nevermind, @LSobanski! I'm now seeing you answered the above in the comment you made in T263817#7087636.

cc @Esanders

Any deployer should be able to create tables. I'm happy to help you with it if you wish.

From a quick look here, I don't see discussion tools listed in https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance/blob/master/createExtensionTables.php, which it needs to be to make table creation easy and convenient. Can it be added to that script?

Once it's done, creating tables should be only a matter of running that script on all wikis where you want that table to be.

Removing the team tag as the deployment is self-service. Adding a few subscribers for visibility.

@LSobanski: to confirm, by "self-service" do you mean the Editing-team should feel empowered to deploy the table to production ourselves?

EDIT: nevermind, @LSobanski! I'm now seeing you answered the above in the comment you made in T263817#7087636.

cc @Esanders

Any deployer should be able to create tables. I'm happy to help you with it if you wish.

From a quick look here, I don't see discussion tools listed in https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance/blob/master/createExtensionTables.php, which it needs to be to make table creation easy and convenient. Can it be added to that script?

Once it's done, creating tables should be only a matter of running that script on all wikis where you want that table to be.

Adding to this, if you need the table to be on all wikis, you also need to modify addWiki.php.

Change 695517 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/WikimediaMaintenance@master] Add DiscussionTools to createExtensionTables

https://gerrit.wikimedia.org/r/695517

Change 695517 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Add DiscussionTools to createExtensionTables

https://gerrit.wikimedia.org/r/695517

With the patch being merged, I gather that we're now waiting on it being deployed so that the very helpful @Urbanecm can run the script for us. Since there's no train next week, that means we're looking at somewhere around the 8th to 10th (depending on how far down the deployment process it has to go before it's runnable from mwmaint).

I confirmed on our standup this morning that this timeframe shouldn't be an issue, as we're not planning on making the config change to enable the feature in beta before then anyway. If we do need to move faster, there are backport windows next week that we could use to get it out sooner.

With the patch being merged, I gather that we're now waiting on it being deployed so that the very helpful @Urbanecm can run the script for us. Since there's no train next week, that means we're looking at somewhere around the 8th to 10th (depending on how far down the deployment process it has to go before it's runnable from mwmaint).

That is right. The patch should be deployed at all wikis the table is supposed to live on - since we will create it at all wikis, that means train reaches group2. Putting a reminder to look here the next next week :).

Mentioned in SAL (#wikimedia-operations) [2021-06-10T21:33:36Z] <urbanecm> [urbanecm@mwmaint1002 ~]$ mwscript extensions/WikimediaMaintenance/createExtensionTables.php --wiki=testwiki discussiontools # T282699

Mentioned in SAL (#wikimedia-operations) [2021-06-10T21:36:16Z] <urbanecm> Start of urbanecm@mwmaint1002:~$ foreachwiki extensions/WikimediaMaintenance/createExtensionTables.php discussiontools # T282699

Mentioned in SAL (#wikimedia-operations) [2021-06-10T21:40:32Z] <urbanecm> End of urbanecm@mwmaint1002:~$ foreachwiki extensions/WikimediaMaintenance/createExtensionTables.php discussiontools # T282699

Urbanecm added a subscriber: DLynch.

Train reached group2, so I went ahead and created the table. The table should now be live at all Wikimedia wikis (see output of DESCRIBE below and P16422 for script transcript).

Output of DESCRIBE
wikiadmin@10.64.0.44(testwiki)> describe discussiontools_subscription;
+---------------+------------------+------+-----+---------+----------------+
| Field         | Type             | Null | Key | Default | Extra          |
+---------------+------------------+------+-----+---------+----------------+
| sub_id        | int(10) unsigned | NO   | PRI | NULL    | auto_increment |
| sub_item      | varbinary(255)   | NO   | MUL | NULL    |                |
| sub_namespace | int(11)          | NO   |     | 0       |                |
| sub_title     | varbinary(255)   | NO   |     | NULL    |                |
| sub_section   | varbinary(255)   | NO   |     | NULL    |                |
| sub_state     | int(11)          | NO   |     | 1       |                |
| sub_user      | int(10) unsigned | NO   | MUL | NULL    |                |
| sub_created   | binary(14)       | NO   |     | NULL    |                |
| sub_notified  | binary(14)       | YES  |     | NULL    |                |
+---------------+------------------+------+-----+---------+----------------+
9 rows in set (0.00 sec)

wikiadmin@10.64.0.44(testwiki)>

wikiadmin@10.64.0.43(cswiki)> describe discussiontools_subscription;
+---------------+------------------+------+-----+---------+----------------+
| Field         | Type             | Null | Key | Default | Extra          |
+---------------+------------------+------+-----+---------+----------------+
| sub_id        | int(10) unsigned | NO   | PRI | NULL    | auto_increment |
| sub_item      | varbinary(255)   | NO   | MUL | NULL    |                |
| sub_namespace | int(11)          | NO   |     | 0       |                |
| sub_title     | varbinary(255)   | NO   |     | NULL    |                |
| sub_section   | varbinary(255)   | NO   |     | NULL    |                |
| sub_state     | int(11)          | NO   |     | 1       |                |
| sub_user      | int(10) unsigned | NO   | MUL | NULL    |                |
| sub_created   | binary(14)       | NO   |     | NULL    |                |
| sub_notified  | binary(14)       | YES  |     | NULL    |                |
+---------------+------------------+------+-----+---------+----------------+
9 rows in set (0.00 sec)

wikiadmin@10.64.0.43(cswiki)>

Anything else I can help with here?

matmarex added a subscriber: matmarex.

Thank you, I think that's all we need!