Page MenuHomePhabricator
Create Task
Maniphest T282711

Homepage: footer of topic filter overlaps topics
Closed, ResolvedPublicBUG REPORT
Actions

Description

I noticed today, at the bottom of the topic dialog in the suggested edits module, that the footer overlaps the buttons when I scroll. This was on desktop on English Wikipedia in production. See the screenshot.

image.png (196×676 px, 29 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+4 -0Suggested edits: Set footer color for topic filter dialog
mediawiki/extensions/GrowthExperimentsmaster+4 -0Suggested edits: Set footer color for topic filter dialog
Customize query in gerrit

Related Objects

Event Timeline

MMiller_WMF created this task.May 12 2021, 5:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2021, 5:07 PM
MMiller_WMF updated the task description. (Show Details)May 12 2021, 5:08 PM
kostajh triaged this task as Medium priority.May 12 2021, 5:13 PM
kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
kostajh changed the subtype of this task from "Task" to "Bug Report".

Moving to current sprint as a (hopefully) relatively easy fix and also due to its prominence in the newcomer workflow.

kostajh lowered the priority of this task from Medium to Low.May 12 2021, 5:13 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.

... but lowering the priority below most Add-Link tasks.

• mewoph claimed this task.May 12 2021, 6:32 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
gerritbot added a comment.May 12 2021, 6:35 PM

Change 690009 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Set overlay window's footer color

https://gerrit.wikimedia.org/r/690009

gerritbot added a project: Patch-For-Review.May 12 2021, 6:35 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.May 12 2021, 6:35 PM

Difficulty filter

Screen Shot 2021-05-12 at 11.34.59 AM.png (954×1 px, 152 KB)

Topics filter

Screen Shot 2021-05-12 at 11.34.53 AM.png (960×1 px, 161 KB)

kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.May 12 2021, 9:23 PM
gerritbot added a comment.May 12 2021, 10:07 PM

Change 690009 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Set footer color for topic filter dialog

https://gerrit.wikimedia.org/r/690009

Maintenance_bot removed a project: Patch-For-Review.May 12 2021, 10:10 PM
MMiller_WMF renamed this task from Homepage: footer of difficulty filter overlaps topics to Homepage: footer of topic filter overlaps topics.May 12 2021, 10:30 PM
gerritbot added a comment.May 13 2021, 5:39 PM

Change 690080 had a related patch set uploaded (by Gergő Tisza; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Suggested edits: Set footer color for topic filter dialog

https://gerrit.wikimedia.org/r/690080

gerritbot added a project: Patch-For-Review.May 13 2021, 5:39 PM
gerritbot added a comment.May 13 2021, 6:25 PM

Change 690080 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Suggested edits: Set footer color for topic filter dialog

https://gerrit.wikimedia.org/r/690080

Stashbot added a comment.May 13 2021, 6:35 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-13T18:35:03Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/GrowthExperiments/: 0856ae1: ca52e78: GrowthExperiments backports (T282711, T282175) (duration: 01m 08s)

Stashbot mentioned this in T282175: Add link: an image placeholder flickers when Yes button clicked.May 13 2021, 6:35 PM
Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 7:11 PM
Etonkovidova added a comment.May 19 2021, 7:51 PM

Checked in testwiki wmf.6 - the issue is not present.

Etonkovidova closed this task as Resolved.May 19 2021, 7:51 PM
• mewoph mentioned this in T300031: regression: Difficulty filters cut off at bottom of dialog.Jan 25 2022, 5:02 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL