Page MenuHomePhabricator
Create Task
Maniphest T282731

Wikibase\...: TypeError: Argument 1 passed to GrowthExperiments\...\LinkRecommendationStore::__construct() must implement interface ...\IDatabase, null given
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/690007
https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/63694/console

20:37:53 1) Wikibase\Repo\Tests\GlobalStateFactoryMethodsResourceTest::testHookHandler with data set #4 ('EntityDataPurger')
20:37:53 TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\AddLink\LinkRecommendationStore::__construct() must implement interface Wikimedia\Rdbms\IDatabase, null given, called in /workspace/src/extensions/GrowthExperiments/ServiceWiring.php on line 200
20:37:53 
20:37:53 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddLink/LinkRecommendationStore.php:39
20:37:53 /workspace/src/extensions/GrowthExperiments/ServiceWiring.php:200
20:37:53 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
20:37:53 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
20:37:53 /workspace/src/includes/MediaWikiServices.php:268
20:37:53 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:424
20:37:53 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php:209
20:37:53 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php:150
20:37:53 /workspace/src/includes/HookContainer/HookContainer.php:465
20:37:53 /workspace/src/includes/HookContainer/HookContainer.php:156
20:37:53 /workspace/src/includes/HookContainer/HookRunner.php:3677
20:37:53 /workspace/src/includes/specialpage/SpecialPageFactory.php:1099
20:37:53 /workspace/src/includes/specialpage/SpecialPageFactory.php:1114
20:37:53 /workspace/src/includes/specialpage/SpecialPageFactory.php:1486
20:37:53 /workspace/src/includes/specialpage/SpecialPage.php:124
20:37:53 /workspace/src/includes/specialpage/SpecialPage.php:109
20:37:53 /workspace/src/extensions/Wikibase/repo/WikibaseRepo.ServiceWiring.php:677
20:37:53 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
20:37:53 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
20:37:53 /workspace/src/includes/MediaWikiServices.php:268
20:37:53 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:424
20:37:53 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php:209
20:37:53 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php:150
20:37:53 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/GlobalStateFactoryMethodsResourceTest.php:56
20:37:53 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:449
20:37:53 === Logs generated by test case
20:37:53 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
20:37:53 [localisation] [debug] LocalisationCache using store LCStoreNull []
20:37:53 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
20:37:53 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
20:37:53 [objectcache] [debug] MainObjectStash using store {class} {"class":"HashBagOStuff"}
20:37:53 ===

Details

SubjectRepoBranchLines +/-
repo: Mock getLazyConnectionRefmediawiki/extensions/WikibaseREL1_36+11 -0
Backport CI fixesmediawiki/extensions/Wikibasewmf/1.37.0-wmf.4+11 -13
Backport CI fixesmediawiki/extensions/Wikibasemaster+11 -13
repo: Mock getLazyConnectionRefmediawiki/extensions/Wikibasewmf/1.37.0-wmf.5+11 -0
repo: Mock getLazyConnectionRefmediawiki/extensions/Wikibasewmf/1.37.0-wmf.4+11 -0
repo: Mock getLazyConnectionRefmediawiki/extensions/Wikibasemaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 12 2021, 7:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2021, 7:03 PM
Tgr mentioned this in T282720: GrowthExperiments / SuggestedEditsTest: Call to undefined method Mock_PageViewService_963a7339::supports().May 12 2021, 7:03 PM
Tgr added a comment.May 12 2021, 7:07 PM

The test triggers the SpecialPage_initList hook in HomepageHooks, which has LinkRecommendationStore as a dependency, which fetches a DB handle from the load balancer as its dependency, and presumably the Wikibase test mocks something related to that?

kostajh subscribed.May 12 2021, 7:12 PM
In T282731#7083355, @Tgr wrote:

The test triggers the SpecialPage_initList hook in HomepageHooks, which has LinkRecommendationStore as a dependency, which fetches a DB handle from the load balancer as its dependency, and presumably the Wikibase test mocks something related to that?

Yes, looks that way:

	protected function setUp(): void {
		parent::setUp();

		// Factory methods should never access the database or do http requests
		// https://phabricator.wikimedia.org/T243729
		$this->disallowDBAccess();
		$this->disallowHttpAccess();
	}

from repo/tests/phpunit/includes/GlobalStateFactoryMethodsResourceTest.php.

Tgr added a comment.May 12 2021, 7:14 PM

This is a side effect of disallowDBAccess() (T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove) apparently.

gerritbot added a comment.May 12 2021, 7:20 PM

Change 690032 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/690032

gerritbot added a project: Patch-For-Review.May 12 2021, 7:20 PM
gerritbot added a comment.May 12 2021, 7:49 PM

Change 690032 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@master] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/690032

gerritbot added a comment.May 12 2021, 7:55 PM

Change 689899 had a related patch set uploaded (by Jforrester; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/689899

gerritbot added a comment.May 12 2021, 7:55 PM

Change 689900 had a related patch set uploaded (by Jforrester; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.5] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/689900

kostajh triaged this task as Unbreak Now! priority.May 12 2021, 9:23 PM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 12 2021, 9:39 PM

Change 689899 abandoned by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] repo: Mock getLazyConnectionRef

Reason:

needs to be squashed

https://gerrit.wikimedia.org/r/689899

gerritbot added a comment.May 12 2021, 9:45 PM

Change 690045 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

gerritbot added a comment.May 12 2021, 10:41 PM

Change 689900 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.5] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/689900

gerritbot added a comment.May 12 2021, 11:39 PM

Change 690045 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

gerritbot added a comment.May 12 2021, 11:52 PM

Change 690066 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

gerritbot added a comment.May 12 2021, 11:57 PM

Change 690066 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

Tgr closed this task as Resolved.May 13 2021, 12:08 AM
Tgr assigned this task to kostajh.
Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 12:10 AM
gerritbot added a comment.Apr 9 2022, 3:52 PM

Change 778627 had a related patch set uploaded (by Umherirrender; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@REL1_36] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/778627

gerritbot added a project: Patch-For-Review.Apr 9 2022, 3:52 PM
gerritbot added a comment.Apr 9 2022, 4:31 PM

Change 778627 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/778627

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2022, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL