Page MenuHomePhabricator
Create Task
Maniphest T282735

Wikimedia\Rdbms\DBQueryError: Error 1048: Column 'gt_page_id' cannot be null (db1138)Function: GeoData\Hooks::doLinksUpdateQuery: INSERT INTO `geo_tags` (gt_page_id,gt_id,gt_lat,gt_lon,gt_globe,gt_primary,gt_dim,gt_type,gt_name,gt_country,gt_region) VALUES (NULL,NULL,'45.811666666667','4.9194444444444','earth',1,1000,'camera',NULL,NULL,NULL)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Rdbms\DBQueryError: Error 1048: Column 'gt_page_id' cannot be null (db1138)
Function: GeoData\Hooks::doLinksUpdate
Query: INSERT INTO `geo_tags` (gt_page_id,gt_id,gt_lat,gt_lon,gt_globe,gt_primary,gt_dim,gt_type,gt_na
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/Database.php(1759)
#0 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/Database.php(1743): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/Database.php(1718): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/Database.php(1282): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/Database.php(2405): Wikimedia\Rdbms\Database->query(string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/Database.php(2385): Wikimedia\Rdbms\Database->doInsert(string, array, string)
#5 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->insert(string, array, string)
#6 /srv/mediawiki/php-1.37.0-wmf.5/includes/libs/rdbms/database/DBConnRef.php(373): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#7 /srv/mediawiki/php-1.37.0-wmf.5/extensions/GeoData/includes/Hooks.php(226): Wikimedia\Rdbms\DBConnRef->insert(string, array, string)
#8 /srv/mediawiki/php-1.37.0-wmf.5/extensions/GeoData/includes/Hooks.php(142): GeoData\Hooks::doLinksUpdate(array, NULL, integer)
#9 /srv/mediawiki/php-1.37.0-wmf.5/extensions/GeoData/includes/Hooks.php(250): GeoData\Hooks::onLinksUpdateComplete(LinksUpdate)
#10 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/MWCallableUpdate.php(38): GeoData\Hooks::GeoData\{closure}()
#11 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/DeferredUpdates.php(513): MWCallableUpdate->doUpdate()
#12 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#13 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#14 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#15 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#16 /srv/mediawiki/php-1.37.0-wmf.5/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#17 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(1127): DeferredUpdates::doUpdates(string)
#18 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(837): MediaWiki->restInPeace()
#19 /srv/mediawiki/php-1.37.0-wmf.5/api.php(125): MediaWiki->doPostOutputShutdown()
#20 /srv/mediawiki/php-1.37.0-wmf.5/api.php(45): wfApiMain()
#21 /srv/mediawiki/w/api.php(3): require(string)
#22 {main}
Notes

These started showing up when I rolled group1 to wmf.5. Please investigate. group1 has been rolled back to wmf.4 in the meantime.

Details

Request URL
https://commons.wikimedia.org/w/api.php
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make sure mId existsmediawiki/extensions/GeoDatawmf/1.37.0-wmf.5+18 -0
Make sure mId existsmediawiki/extensions/GeoDatamaster+18 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

dancy created this task.May 12 2021, 7:10 PM
dancy triaged this task as Unbreak Now! priority.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 12 2021, 7:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dancy added a parent task: T281146: 1.37.0-wmf.5 deployment blockers.May 12 2021, 7:11 PM
dancy updated the task description. (Show Details)
Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.May 12 2021, 7:45 PM
Zabe subscribed.May 12 2021, 7:53 PM
EBernhardson subscribed.May 12 2021, 8:08 PM
Zabe added a comment.EditedMay 12 2021, 9:07 PM

Fairly certain this is caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684816

Here is my attempt to fix the issue.

gerritbot added a comment.May 12 2021, 9:07 PM

Change 690037 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GeoData@master] Make sure mId exists

https://gerrit.wikimedia.org/r/690037

gerritbot added a project: Patch-For-Review.May 12 2021, 9:07 PM
brennen mentioned this in T281146: 1.37.0-wmf.5 deployment blockers.May 12 2021, 11:10 PM
gerritbot added a comment.May 13 2021, 4:09 PM

Change 690037 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Make sure mId exists

https://gerrit.wikimedia.org/r/690037

gerritbot added a comment.May 13 2021, 4:10 PM

Change 690078 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GeoData@wmf/1.37.0-wmf.5] Make sure mId exists

https://gerrit.wikimedia.org/r/690078

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 13 2021, 5:00 PM
• Agusbou2015 subscribed.May 13 2021, 6:33 PM
gerritbot added a comment.May 13 2021, 7:35 PM

Change 690078 merged by jenkins-bot:

[mediawiki/extensions/GeoData@wmf/1.37.0-wmf.5] Make sure mId exists

https://gerrit.wikimedia.org/r/690078

Stashbot added a comment.May 13 2021, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-13T19:39:01Z] <dancy@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/GeoData/includes/Hooks.php: Backport: [[gerrit:690078|Make sure mId exists (T282735)]] (duration: 01m 08s)

dancy added a comment.May 13 2021, 7:52 PM

https://gerrit.wikimedia.org/r/690078 has been deployed to group0 and group1. No errors seen so far.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 13 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 8:10 PM
dancy closed this task as Resolved.May 13 2021, 9:28 PM
dancy claimed this task.

@Zabe Thanks for the fix!

Zabe claimed this task.May 28 2021, 4:32 PM
Zabe added a project: User-Zabe.
Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM
Zabe removed a project: User-Zabe.Apr 13 2022, 12:47 AM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.Feb 11 2025, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits