Page MenuHomePhabricator
Create Task
Maniphest T282744

Wikibase\...\EditFilterHookRunnerTest: Context should not be altered
Closed, ResolvedPublic
Actions

Description

Y

Details

SubjectRepoBranchLines +/-
Backport CI fixesmediawiki/extensions/Wikibasewmf/1.37.0-wmf.4+11 -13
Backport CI fixesmediawiki/extensions/Wikibasemaster+11 -13
EditFilterHookRunnerTest: do not check for context changesmediawiki/extensions/Wikibasemaster+0 -13
EditFilterHookRunnerTest: do not check for context changesmediawiki/extensions/Wikibasewmf/1.37.0-wmf.4+0 -13
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 12 2021, 8:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2021, 8:24 PM
Tgr added a comment.May 12 2021, 8:29 PM

Presumably broken by ConfigHooks::onEditFilterMergedContent. It doesn't do anything with the context or config, thou

Tgr added a comment.May 12 2021, 8:42 PM

I suppose something calls getConfig() which causes RequestContext to lazy-initialize the config. It's not happening in the GrowthExperiments EditFilterMergedContent hook, though.

Jdforrester-WMF subscribed.May 12 2021, 8:45 PM
Tgr added a project: MediaWiki-extensions-WikibaseRepository.May 12 2021, 9:05 PM
Tgr added a subscriber: kostajh.

@kostajh pointed out that the error only occurs in wmf.4 where that hook did call that. (Was removed in rEGREa3226bd368ea: Change validation in ConfigHooks to use ConfigValidatorFactory.) That test is a bad idea though, it invokes hooks, it cannot expect that nothing will access RequestContext getters.

gerritbot added a comment.May 12 2021, 9:10 PM

Change 690042 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/Wikibase@master] EditFilterHookRunnerTest: do not check for context changes

https://gerrit.wikimedia.org/r/690042

gerritbot added a project: Patch-For-Review.May 12 2021, 9:10 PM
gerritbot added a comment.May 12 2021, 9:19 PM

Change 689903 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] EditFilterHookRunnerTest: do not check for context changes

https://gerrit.wikimedia.org/r/689903

kostajh triaged this task as Unbreak Now! priority.May 12 2021, 9:23 PM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 12 2021, 9:39 PM

Change 689903 abandoned by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] EditFilterHookRunnerTest: do not check for context changes

Reason:

needs to be squashed

https://gerrit.wikimedia.org/r/689903

gerritbot added a comment.May 12 2021, 9:45 PM

Change 690045 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

Maintenance_bot added a project: Wikidata.May 12 2021, 9:45 PM
gerritbot added a comment.May 12 2021, 10:07 PM

Change 690042 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] EditFilterHookRunnerTest: do not check for context changes

https://gerrit.wikimedia.org/r/690042

gerritbot added a comment.May 12 2021, 11:39 PM

Change 690045 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

gerritbot added a comment.May 12 2021, 11:52 PM

Change 690066 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

gerritbot added a comment.May 12 2021, 11:57 PM

Change 690066 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

Jdforrester-WMF closed this task as Resolved.May 13 2021, 12:07 AM
Jdforrester-WMF assigned this task to Tgr.
Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 12:10 AM
• Leoyon8 reopened this task as Stalled.May 26 2021, 5:57 AM
• Leoyon8 removed Tgr as the assignee of this task.
• Leoyon8 lowered the priority of this task from Unbreak Now! to Medium.
• Leoyon8 updated the task description. (Show Details)
• Leoyon8 removed projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Growth-Team (Sprint 0 (Growth Team)), ci-test-error (WMF-deployed Build Failure), GrowthExperiments.
• Leoyon8 removed subscribers: kostajh, Jdforrester-WMF, Aklapper, Tgr.
Legoktm closed this task as Resolved.May 26 2021, 6:11 AM
Legoktm assigned this task to Tgr.
Legoktm raised the priority of this task from Medium to Unbreak Now!.
Legoktm added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Growth-Team (Sprint 0 (Growth Team)), ci-test-error (WMF-deployed Build Failure), GrowthExperiments.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL