Page MenuHomePhabricator

Wikibase\...\EditFilterHookRunnerTest: Context should not be altered
Closed, ResolvedPublic

Description

Y

Event Timeline

Presumably broken by ConfigHooks::onEditFilterMergedContent. It doesn't do anything with the context or config, thou

I suppose something calls getConfig() which causes RequestContext to lazy-initialize the config. It's not happening in the GrowthExperiments EditFilterMergedContent hook, though.

Tgr added a subscriber: kostajh.

@kostajh pointed out that the error only occurs in wmf.4 where that hook did call that. (Was removed in rEGREa3226bd368ea: Change validation in ConfigHooks to use ConfigValidatorFactory.) That test is a bad idea though, it invokes hooks, it cannot expect that nothing will access RequestContext getters.

Change 690042 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/Wikibase@master] EditFilterHookRunnerTest: do not check for context changes

https://gerrit.wikimedia.org/r/690042

Change 689903 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] EditFilterHookRunnerTest: do not check for context changes

https://gerrit.wikimedia.org/r/689903

kostajh triaged this task as Unbreak Now! priority.May 12 2021, 9:23 PM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change 689903 abandoned by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] EditFilterHookRunnerTest: do not check for context changes

Reason:

needs to be squashed

https://gerrit.wikimedia.org/r/689903

Change 690045 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

Change 690042 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] EditFilterHookRunnerTest: do not check for context changes

https://gerrit.wikimedia.org/r/690042

Change 690045 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

Change 690066 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

Change 690066 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

Leoyon8 removed Tgr as the assignee of this task.
Leoyon8 lowered the priority of this task from Unbreak Now! to Medium.
Leoyon8 updated the task description. (Show Details)