Page MenuHomePhabricator

[M lg] Opt-in no prompt doesn't fit with new blue background
Closed, ResolvedPublic

Description

Banner: https://en.m.wikipedia.org/wiki/Wikipedia?banner=B2021_0101_en6C_m_p1_lg_template&country=GB

The "Sorry to hear that..." prompt which comes up when a user selects No for opt-in, doesn't fit the new pale blue background for the section. It shouldn't touch the edges, and maybe it would be best to get rid of the blue prompt background completely? Should also reconsider if the typing animation is needed.

en.m.wikipedia.org_wiki_Wikipedia_banner=B2021_0101_en6C_m_p1_lg_template&country=GB(Pixel 2 XL).png (2×1 px, 444 KB)

Event Timeline

Yeah I had also noticed this earlier...wasnt sure if that was by design. Thanks for filing this @Pcoombe!

I would propose that we do away with the bubble background on that message. None of the other text is in an inner dark blue bubble any more. Here's a banner with that removed:

https://en.m.wikipedia.org/wiki/Wikipedia?banner=trilogy_en6C_m_p1_lg_noBubbles&country=GB

I left the typing animation in that one.

Background color on top text is corrected now in my proposed banner.

Thanks Eric!
@jbolorinos-ctr, could you run QA on the above banner so that we can adopt into current best?
Thank you!

Hey @EWilfong_WMF, minor nit-pick on this one, I noticed there are sometimes orphan texts visible on the prompt, is that something we should fix in this case?

image.png (607×1 px, 174 KB)

@jbolorinos-ctr - That happens in current best as well, correct? Just trying to fix the issue with the spacing of the text bubble here.

I don't have a concern with the orphan text personally, but if we want to address maybe we can do so in a different task?

IMO it's not reasonable to try and avoid "orphan text" given the range of translations and screen sizes we work with.

Agree that fixing orphan text is not worth it on responsive text elements like this. If we fix it in one size, it might cause orphan text on another screen size.

Do you agree @Pcoombe , it's probably only worth reporting/fixing these if they're appearing on a fixed-width element at its maximum width?

Yes, maybe in the situation of a fixed-width element. But otherwise I don't think we should worry about this.

Sounds good.
I applied this to current best @EWilfong_WMF @Pcoombe.

Thanks everyone for your inputs! Closing this issue as resolved then!