Page MenuHomePhabricator

Revert workaround for cumin output verbosity on RemoteExecution (CuminExecution) abstraction
Open, LowPublic

Description

Cumin used to not being able to suppress its verbose output, which was way too much for regular usage (not debug) as a remote execution api.

@Volans just communicated that the latest version of cumin fixes this behaviour (which version to check for?). We no longer need to apply the "/dev/null" trick, and we can tell cumin independently to print or not the command output and the progress bars.

This means we can change the temporary workaround implemented at: https://gerrit.wikimedia.org/r/c/operations/software/wmfmariadbpy/+/597069/7/transferpy/RemoteExecution/CuminExecution.py

(this should now live on RemoteExecution on wmfmariadbpy)

and implement the right cumin options for verbose and non-verbose modes there. There is no urgency here, but it is a "cleanup" we can do at some point.

Event Timeline

LSobanski moved this task from Triage to Ready on the DBA board.

Version is 4.1.0, currently latest on apt.w.o and PyPI and deployed to all cumin hosts in production.
See worker.reporter and worker.progress_bars on https://doc.wikimedia.org/cumin/master/introduction.html#library for an example of how to implement it.

I coded RemoteExecution initially for the backup library. But I had to give up ownership of it and got moved to the wmfmariadbpy library. It is all now owned by @Kormat/DBAs.

Thanks for the update, so it is still a valid task :)

Removing cumin, and I/F tags as there isn't anything pending from this side.