Page MenuHomePhabricator
Create Task
Maniphest T282820

Replace `function-schemata` Schema.validate with validate status
Closed, ResolvedPublic
Actions

Description

Currently sets errors as a member of Schema object, which won't work in an async context.

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (a28d2df)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (a28d2df)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (f615309)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (afc9127)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (a28d2df)mediawiki/extensions/WikiLambdamaster+1 -1
Remove outdated comments related to T282820mediawiki/services/function-schematamaster+0 -6
Turn on validation for function call testsmediawiki/services/function-orchestratormaster+62 -62
Replace schemaValidator.validate() with schemaValidator.validateStatus()mediawiki/services/function-orchestratormaster+3 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.May 13 2021, 7:24 PM
DVrandecic subscribed.May 13 2021, 7:49 PM

Is the bool always the same as "is the list of errors empty"?

DVrandecic added a project: WikiLambda Front-end.May 13 2021, 8:10 PM
DVrandecic moved this task from To triage to To triage: Un-phased work on the Abstract Wikipedia team board.May 26 2021, 4:46 PM
Jdforrester-WMF added a project: function-schemata.May 26 2021, 8:50 PM
Lindsaykwardell removed a project: WikiLambda Front-end.Jun 23 2021, 9:59 PM
DVrandecic triaged this task as High priority.Jul 14 2021, 4:54 PM
cmassaro raised the priority of this task from High to Needs Triage.Aug 3 2021, 6:31 PM
cmassaro moved this task from To triage: Un-phased work to To triage on the Abstract Wikipedia team board.
cmassaro added a parent task: T288120: Get Z5s Tight and Right.Aug 4 2021, 4:08 PM
Jdforrester-WMF edited parent tasks, added: T288123: Re-work Z5/Error model and handling; removed: T288120: Get Z5s Tight and Right.Aug 15 2021, 9:47 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Aug 25 2021, 4:25 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic renamed this task from `function-schemata` Schema.validate should return pair<bool, errors> to Replace `function-schemata` Schema.validate with validate status.Oct 6 2021, 4:35 PM
DVrandecic triaged this task as Medium priority.
DVrandecic edited projects, added function-orchestrator; removed function-schemata.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 3 2021, 4:33 PM
DMartin-WMF mentioned this in T296676: Propagate Validator Errors as Z5s.Jan 27 2022, 7:21 PM
DMartin-WMF claimed this task.Jan 31 2022, 6:08 AM
DMartin-WMF moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 31 2022, 7:36 PM
gerritbot added a comment.Feb 2 2022, 6:13 AM

Change 759144 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Replace schemaValidator.validate() with schemaValidator.validateStatus()

https://gerrit.wikimedia.org/r/759144

gerritbot added a project: Patch-For-Review.Feb 2 2022, 6:13 AM
gerritbot added a comment.Feb 2 2022, 9:34 PM

Change 759340 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Turn on validation for function call tests

https://gerrit.wikimedia.org/r/759340

gerritbot added a comment.Feb 2 2022, 9:48 PM

Change 759144 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Replace schemaValidator.validate() with schemaValidator.validateStatus()

https://gerrit.wikimedia.org/r/759144

DMartin-WMF mentioned this in rMSFO750c2bbfa95d: Replace schemaValidator.validate() with schemaValidator.validateStatus().Feb 2 2022, 9:48 PM
gerritbot added a comment.Feb 2 2022, 10:54 PM

Change 759340 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Turn on validation for function call tests

https://gerrit.wikimedia.org/r/759340

Jdforrester-WMF mentioned this in rMSFO397792081ae3: Turn on validation for function call tests.Feb 2 2022, 10:55 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 2 2022, 11:11 PM
Jdforrester-WMF subscribed.Feb 23 2022, 6:36 PM

Is this complete?

gerritbot added a comment.Feb 26 2022, 5:27 AM

Change 766210 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Remove outdated comments related to T282820

https://gerrit.wikimedia.org/r/766210

gerritbot added a project: Patch-For-Review.Feb 26 2022, 5:27 AM
gerritbot added a comment.Feb 28 2022, 4:06 PM

Change 766210 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Remove outdated comments related to T282820

https://gerrit.wikimedia.org/r/766210

DMartin-WMF mentioned this in rMSFS7ab9a89e41f6: Remove outdated comments related to T282820.Feb 28 2022, 4:13 PM
DMartin-WMF moved this task from In progress to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 28 2022, 4:21 PM
gerritbot added a comment.Mar 1 2022, 12:59 AM

Change 766886 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766886

gerritbot added a comment.Mar 1 2022, 12:59 AM

Change 766887 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766887

gerritbot added a comment.Mar 1 2022, 12:59 AM

Change 766888 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766888

gerritbot added a comment.Mar 1 2022, 3:34 PM

Change 767201 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (afc9127)

https://gerrit.wikimedia.org/r/767201

gerritbot added a comment.Mar 1 2022, 3:41 PM

Change 767204 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (f615309)

https://gerrit.wikimedia.org/r/767204

gerritbot added a comment.Mar 1 2022, 3:46 PM

Change 766886 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766886

gerritbot added a comment.Mar 1 2022, 4:00 PM

Change 766888 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766888

gerritbot added a comment.Mar 1 2022, 4:00 PM

Change 766887 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766887

Jdforrester-WMF mentioned this in rMSFO06c241d4496c: Update function-schemata sub-module to HEAD (a28d2df).Mar 1 2022, 4:01 PM
gerritbot added a comment.Mar 1 2022, 4:02 PM

Change 767201 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (afc9127)

Reason:

https://gerrit.wikimedia.org/r/767201

gerritbot added a comment.Mar 1 2022, 4:02 PM

Change 767204 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (f615309)

Reason:

https://gerrit.wikimedia.org/r/767204

Jdforrester-WMF mentioned this in rMSFEc008ccbd6a6f: Update function-schemata sub-module to HEAD (a28d2df).Mar 1 2022, 4:02 PM
DVrandecic closed this task as Resolved.Mar 8 2022, 5:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL